You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by ch...@apache.org on 2022/12/05 01:43:20 UTC
[bookkeeper] branch master updated: remove unused attempts (#3685)
This is an automated email from the ASF dual-hosted git repository.
chenhang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/bookkeeper.git
The following commit(s) were added to refs/heads/master by this push:
new 542926c163 remove unused attempts (#3685)
542926c163 is described below
commit 542926c1637c2dc295d4ccea16d9e266d1328cf4
Author: LinChen <15...@qq.com>
AuthorDate: Mon Dec 5 09:43:13 2022 +0800
remove unused attempts (#3685)
### Motivation
remove unused variable attempts:
https://github.com/apache/bookkeeper/blob/01232c94c91759a175345e8c055951e5cc6091dd/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/directentrylogger/DirectReader.java#L209-L215
---
.../bookkeeper/bookie/storage/directentrylogger/DirectReader.java | 3 ---
1 file changed, 3 deletions(-)
diff --git a/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/directentrylogger/DirectReader.java b/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/directentrylogger/DirectReader.java
index d135807b2e..445b0597b5 100644
--- a/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/directentrylogger/DirectReader.java
+++ b/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/directentrylogger/DirectReader.java
@@ -207,12 +207,9 @@ class DirectReader implements LogReader {
long bufferOffset = 0;
long bytesToRead = Math.min(blockSize, bytesAvailable);
long bytesOutstanding = bytesToRead;
- int attempts = 0;
long bytesRead = -1;
try {
while (true) {
- attempts++;
-
long readSize = blockSize - bufferOffset;
long pointerWithOffset = nativeBuffer.pointer(bufferOffset, readSize);
bytesRead = nativeIO.pread(fd, pointerWithOffset,