You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "Fix-Point (via GitHub)" <gi...@apache.org> on 2024/09/19 01:52:12 UTC
[PR] sched/signal: Simplified Implementation for SIGEV_THREAD_TID [nuttx]
Fix-Point opened a new pull request, #13530:
URL: https://github.com/apache/nuttx/pull/13530
## Summary
This commit simplified the implementation for SIGEV_THREAD_TID and added the missing siginfo initializer.
## Impact
POSIX timer with SIGEV_THREAD_TID flag.
## Testing
Tested on QEMU using rt-tests/cyclictest.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] sched/signal: Simplified Implementation for SIGEV_THREAD_TID [nuttx]
Posted by "lupyuen (via GitHub)" <gi...@apache.org>.
lupyuen commented on PR #13530:
URL: https://github.com/apache/nuttx/pull/13530#issuecomment-2359820145
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13494&type=pullrequests)
**No, this PR does not meet the NuttX requirements.**
Here's why:
* **Insufficient Summary:**
* The summary is too brief. While it mentions the changes made, it lacks crucial details about *why* these changes were necessary. Was there a bug? Did the previous implementation have limitations?
* It doesn't specify which functional part of the code is affected. Is it related to the kernel, a specific driver, or a library?
* **Incomplete Impact Assessment:**
* **Feature Addition/Change:** The impact section vaguely states "POSIX timer with SIGEV_THREAD_TID flag." Be explicit. Is this a new feature? If so, describe its functionality. If it's a change, explain how the existing feature is impacted.
* **Other Impacts:** The PR only addresses impact on users, leaving other aspects like build process, hardware, documentation, security, and compatibility completely unaddressed. Even for user impact, it lacks specifics. How will users interact with this new/modified feature?
* **Insufficient Testing Details:**
* **Limited Testing Environment:** The PR only mentions testing on QEMU. Specify the QEMU version and the specific architecture being emulated. Ideally, testing should be done on real hardware as well, if possible.
* **Missing Build Host Information:** Details about the build host are entirely missing. This includes the operating system, CPU architecture, and the compiler used (including the version).
* **Absent Testing Logs:** The PR provides placeholders for testing logs instead of the actual logs. This makes it impossible to verify the claimed functionality or identify potential issues.
**To improve this PR:**
1. **Expand the Summary:** Explain the rationale behind the changes. Mention the specific code sections (files, functions) that were modified. If applicable, link to a relevant NuttX issue.
2. **Thoroughly Address Impact:** Analyze and describe the impact on all the listed aspects (build, hardware, documentation, security, compatibility). Be specific about how each area is affected.
3. **Provide Comprehensive Testing Information:**
* List all build host environments used, including OS, CPU, and compiler details.
* Mention the specific QEMU version and the emulated architecture.
* Include actual testing logs from both before and after the changes.
* If feasible, add testing results from real hardware platforms.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] sched/signal: Simplified Implementation for SIGEV_THREAD_TID [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #13530:
URL: https://github.com/apache/nuttx/pull/13530#issuecomment-2361378517
@Fix-Point let's revert the commit https://github.com/apache/nuttx/commit/9a9d0a647ef1b123627872ab7e139c1c5b9be1a0 too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] sched/signal: Simplified Implementation for SIGEV_THREAD_TID [nuttx]
Posted by "anchao (via GitHub)" <gi...@apache.org>.
anchao merged PR #13530:
URL: https://github.com/apache/nuttx/pull/13530
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org