You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Steve Loughran (JIRA)" <ji...@apache.org> on 2017/03/13 10:34:04 UTC
[jira] [Commented] (HADOOP-14178) Move Mockito up to version 2.x
[ https://issues.apache.org/jira/browse/HADOOP-14178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15907141#comment-15907141 ]
Steve Loughran commented on HADOOP-14178:
-----------------------------------------
Not an easy update, at least from one review https://asolntsev.github.io/en/2016/10/11/mockito-2.1/
No just from API changes, but a stricter tool finds problems in existing mock declarations. And, given how the outcome on failed mocks is usually a stack trace of hard-to-diagnose issues, that could take time.
The [change long|https://github.com/mockito/mockito/blob/master/doc/release-notes/official.md] makes it clear that for full java 8 support, the update is needed. But: as its not a published dependency of any production artifact, just the test ones, it is a JAR which can be upgraded with less risk than others
> Move Mockito up to version 2.x
> ------------------------------
>
> Key: HADOOP-14178
> URL: https://issues.apache.org/jira/browse/HADOOP-14178
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: test
> Affects Versions: 2.9.0
> Reporter: Steve Loughran
> Priority: Minor
>
> I don't know when Hadoop picked up Mockito, but it has been frozen at 1.8.5 since the switch to maven in 2011.
> Mockito is now at version 2.1, [with lots of Java 8 support|https://github.com/mockito/mockito/wiki/What%27s-new-in-Mockito-2]. That' s not just defining actions as closures, but in supporting Optional types, mocking methods in interfaces, etc.
> It's only used for testing, and, *provided there aren't regressions*, cost of upgrade is low. The good news: test tools usually come with good test coverage. The bad: mockito does go deep into java bytecodes.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org