You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2022/08/10 23:14:48 UTC
[kudu-CR] [tools] fix misprint in one of 'kudu table list' validators
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18831
Change subject: [tools] fix misprint in one of 'kudu table list' validators
......................................................................
[tools] fix misprint in one of 'kudu table list' validators
This is a follow-up to 76d540c137c991127865d5d2455d113677a9afe9.
Change-Id: I7fc01d8540f573d1126d797ba9e951ce4b58d37d
---
M src/kudu/tools/tool_action_table.cc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/31/18831/1
--
To view, visit http://gerrit.cloudera.org:8080/18831
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7fc01d8540f573d1126d797ba9e951ce4b58d37d
Gerrit-Change-Number: 18831
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] [tools] fix misprint in one of 'kudu table list' validators
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/18831 )
Change subject: [tools] fix misprint in one of 'kudu table list' validators
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/18831
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7fc01d8540f573d1126d797ba9e951ce4b58d37d
Gerrit-Change-Number: 18831
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Thu, 11 Aug 2022 03:58:46 +0000
Gerrit-HasComments: No
[kudu-CR] [tools] fix misprint in one of 'kudu table list' validators
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [tools] fix misprint in one of 'kudu table list' validators
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/18831
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I7fc01d8540f573d1126d797ba9e951ce4b58d37d
Gerrit-Change-Number: 18831
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
[kudu-CR] [tools] fix misprint in one of 'kudu table list' validators
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Attila Bukor, Kudu Jenkins, KeDeng,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18831
to look at the new patch set (#2).
Change subject: [tools] fix misprint in one of 'kudu table list' validators
......................................................................
[tools] fix misprint in one of 'kudu table list' validators
This is a follow-up to 76d540c137c991127865d5d2455d113677a9afe9.
Change-Id: I7fc01d8540f573d1126d797ba9e951ce4b58d37d
---
M src/kudu/tools/tool_action_table.cc
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/31/18831/2
--
To view, visit http://gerrit.cloudera.org:8080/18831
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7fc01d8540f573d1126d797ba9e951ce4b58d37d
Gerrit-Change-Number: 18831
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [tools] fix misprint in one of 'kudu table list' validators
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18831 )
Change subject: [tools] fix misprint in one of 'kudu table list' validators
......................................................................
Patch Set 3: Verified+1
unrelated test failures (RELEASE):
* RaftConsensusITest.TestSlowFollower
* ConcurrentRebalancersTest.TwoConcurrentRebalancers/1
--
To view, visit http://gerrit.cloudera.org:8080/18831
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7fc01d8540f573d1126d797ba9e951ce4b58d37d
Gerrit-Change-Number: 18831
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Thu, 11 Aug 2022 04:13:28 +0000
Gerrit-HasComments: No
[kudu-CR] [tools] fix misprint in one of 'kudu table list' validators
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18831 )
Change subject: [tools] fix misprint in one of 'kudu table list' validators
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18831
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7fc01d8540f573d1126d797ba9e951ce4b58d37d
Gerrit-Change-Number: 18831
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Thu, 11 Aug 2022 03:04:20 +0000
Gerrit-HasComments: No
[kudu-CR] [tools] fix misprint in one of 'kudu table list' validators
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18831 )
Change subject: [tools] fix misprint in one of 'kudu table list' validators
......................................................................
[tools] fix misprint in one of 'kudu table list' validators
This is a follow-up to 76d540c137c991127865d5d2455d113677a9afe9.
Change-Id: I7fc01d8540f573d1126d797ba9e951ce4b58d37d
Reviewed-on: http://gerrit.cloudera.org:8080/18831
Reviewed-by: Yingchun Lai <ac...@gmail.com>
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
Tested-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/tools/tool_action_table.cc
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Yingchun Lai: Looks good to me, approved
Abhishek Chennaka: Looks good to me, but someone else must approve
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/18831
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7fc01d8540f573d1126d797ba9e951ce4b58d37d
Gerrit-Change-Number: 18831
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>