[GitHub] [incubator-tvm] jackwish commented on a change in pull request #4611: {QNN] Making scale/zero_points as expr instead of attrs.

[GitBox <gi...@apache.org>]

jackwish commented on a change in pull request #4611: {QNN] Making scale/zero_points as expr instead of attrs.
URL: https://github.com/apache/incubator-tvm/pull/4611#discussion_r362704400
 
 

 ##########
 File path: python/tvm/relay/qnn/op/legalizations.py
 ##########
 @@ -18,9 +18,24 @@
 """Backend QNN related feature registration"""
 from __future__ import absolute_import
 
+import numpy as np
 import tvm
 from tvm import relay
 from .. import op as reg
+from ... import expr as _expr
+
+def get_scalar_from_constant(expr):
 
 Review comment:
   duplicated with the one in `frontend/common.py`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services