You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "rajeshbabu (JIRA)" <ji...@apache.org> on 2012/06/18 13:59:42 UTC
[jira] [Created] (HBASE-6229) AM.assign() should not set table
state to ENABLED directly.
rajeshbabu created HBASE-6229:
---------------------------------
Summary: AM.assign() should not set table state to ENABLED directly.
Key: HBASE-6229
URL: https://issues.apache.org/jira/browse/HBASE-6229
Project: HBase
Issue Type: Bug
Affects Versions: 0.92.2, 0.94.1
Reporter: rajeshbabu
Assignee: rajeshbabu
Fix For: 0.96.0, 0.94.1, 0.92.3
In case of assign from EnableTableHandler table state is ENABLING. Any how EnableTableHandler will set ENABLED after assigning all the the table regions. If we try to set to ENABLED directly then client api may think ENABLE table is completed. When we have a case like all the regions are added directly into META and we call assignRegion then we need to make the table ENABLED. Hence in such case the table will not be in ENABLING or ENABLED state.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6229) AM.assign() should not set table
state to ENABLED directly.
Posted by "rajeshbabu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
rajeshbabu updated HBASE-6229:
------------------------------
Attachment: HBASE-6229_trunk.patch
> AM.assign() should not set table state to ENABLED directly.
> -----------------------------------------------------------
>
> Key: HBASE-6229
> URL: https://issues.apache.org/jira/browse/HBASE-6229
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.2, 0.94.1
> Reporter: rajeshbabu
> Assignee: rajeshbabu
> Fix For: 0.96.0, 0.94.1, 0.92.3
>
> Attachments: HBASE-6229_94.patch, HBASE-6229_trunk.patch
>
>
> In case of assign from EnableTableHandler table state is ENABLING. Any how EnableTableHandler will set ENABLED after assigning all the the table regions. If we try to set to ENABLED directly then client api may think ENABLE table is completed. When we have a case like all the regions are added directly into META and we call assignRegion then we need to make the table ENABLED. Hence in such case the table will not be in ENABLING or ENABLED state.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6229) AM.assign() should not set table
state to ENABLED directly.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398011#comment-13398011 ]
Hudson commented on HBASE-6229:
-------------------------------
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #61 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/61/])
HBASE-6229 AM.assign() should not set table state to ENABLED directly (Rajesh) (Revision 1352262)
Result = FAILURE
tedyu :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
> AM.assign() should not set table state to ENABLED directly.
> -----------------------------------------------------------
>
> Key: HBASE-6229
> URL: https://issues.apache.org/jira/browse/HBASE-6229
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.2, 0.94.1
> Reporter: rajeshbabu
> Assignee: rajeshbabu
> Fix For: 0.96.0, 0.94.1, 0.92.3
>
> Attachments: 6229_trunk_2.patch, HBASE-6229_94.patch, HBASE-6229_94_1.patch, HBASE-6229_94_2.patch, HBASE-6229_trunk.patch, HBASE-6229_trunk_1.patch
>
>
> In case of assign from EnableTableHandler table state is ENABLING. Any how EnableTableHandler will set ENABLED after assigning all the the table regions. If we try to set to ENABLED directly then client api may think ENABLE table is completed. When we have a case like all the regions are added directly into META and we call assignRegion then we need to make the table ENABLED. Hence in such case the table will not be in ENABLING or ENABLED state.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6229) AM.assign() should not set table
state to ENABLED directly.
Posted by "rajeshbabu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
rajeshbabu updated HBASE-6229:
------------------------------
Status: Open (was: Patch Available)
> AM.assign() should not set table state to ENABLED directly.
> -----------------------------------------------------------
>
> Key: HBASE-6229
> URL: https://issues.apache.org/jira/browse/HBASE-6229
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.2, 0.94.1
> Reporter: rajeshbabu
> Assignee: rajeshbabu
> Fix For: 0.96.0, 0.94.1, 0.92.3
>
> Attachments: HBASE-6229_94.patch, HBASE-6229_94_1.patch, HBASE-6229_trunk.patch, HBASE-6229_trunk_1.patch
>
>
> In case of assign from EnableTableHandler table state is ENABLING. Any how EnableTableHandler will set ENABLED after assigning all the the table regions. If we try to set to ENABLED directly then client api may think ENABLE table is completed. When we have a case like all the regions are added directly into META and we call assignRegion then we need to make the table ENABLED. Hence in such case the table will not be in ENABLING or ENABLED state.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6229) AM.assign() should not set table
state to ENABLED directly.
Posted by "rajeshbabu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13395950#comment-13395950 ]
rajeshbabu commented on HBASE-6229:
-----------------------------------
Attached patch for 94 and trunk. Please review and provide comments/suggestions.
> AM.assign() should not set table state to ENABLED directly.
> -----------------------------------------------------------
>
> Key: HBASE-6229
> URL: https://issues.apache.org/jira/browse/HBASE-6229
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.2, 0.94.1
> Reporter: rajeshbabu
> Assignee: rajeshbabu
> Fix For: 0.96.0, 0.94.1, 0.92.3
>
> Attachments: HBASE-6229_94.patch, HBASE-6229_trunk.patch
>
>
> In case of assign from EnableTableHandler table state is ENABLING. Any how EnableTableHandler will set ENABLED after assigning all the the table regions. If we try to set to ENABLED directly then client api may think ENABLE table is completed. When we have a case like all the regions are added directly into META and we call assignRegion then we need to make the table ENABLED. Hence in such case the table will not be in ENABLING or ENABLED state.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6229) AM.assign() should not set table
state to ENABLED directly.
Posted by "rajeshbabu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
rajeshbabu updated HBASE-6229:
------------------------------
Status: Patch Available (was: Open)
> AM.assign() should not set table state to ENABLED directly.
> -----------------------------------------------------------
>
> Key: HBASE-6229
> URL: https://issues.apache.org/jira/browse/HBASE-6229
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.2, 0.94.1
> Reporter: rajeshbabu
> Assignee: rajeshbabu
> Fix For: 0.96.0, 0.94.1, 0.92.3
>
> Attachments: HBASE-6229_94.patch, HBASE-6229_trunk.patch
>
>
> In case of assign from EnableTableHandler table state is ENABLING. Any how EnableTableHandler will set ENABLED after assigning all the the table regions. If we try to set to ENABLED directly then client api may think ENABLE table is completed. When we have a case like all the regions are added directly into META and we call assignRegion then we need to make the table ENABLED. Hence in such case the table will not be in ENABLING or ENABLED state.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6229) AM.assign() should not set table
state to ENABLED directly.
Posted by "rajeshbabu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13396628#comment-13396628 ]
rajeshbabu commented on HBASE-6229:
-----------------------------------
failed test cases are passing locally.
> AM.assign() should not set table state to ENABLED directly.
> -----------------------------------------------------------
>
> Key: HBASE-6229
> URL: https://issues.apache.org/jira/browse/HBASE-6229
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.2, 0.94.1
> Reporter: rajeshbabu
> Assignee: rajeshbabu
> Fix For: 0.96.0, 0.94.1, 0.92.3
>
> Attachments: HBASE-6229_94.patch, HBASE-6229_94_1.patch, HBASE-6229_trunk.patch, HBASE-6229_trunk_1.patch
>
>
> In case of assign from EnableTableHandler table state is ENABLING. Any how EnableTableHandler will set ENABLED after assigning all the the table regions. If we try to set to ENABLED directly then client api may think ENABLE table is completed. When we have a case like all the regions are added directly into META and we call assignRegion then we need to make the table ENABLED. Hence in such case the table will not be in ENABLING or ENABLED state.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6229) AM.assign() should not set table
state to ENABLED directly.
Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13396958#comment-13396958 ]
Zhihong Ted Yu commented on HBASE-6229:
---------------------------------------
Minor comment:
{code}
+ // EnableTableHandler will set ENABLED after assigning all the the table regions. If we
{code}
Remove the redundant 'the' above.
> AM.assign() should not set table state to ENABLED directly.
> -----------------------------------------------------------
>
> Key: HBASE-6229
> URL: https://issues.apache.org/jira/browse/HBASE-6229
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.2, 0.94.1
> Reporter: rajeshbabu
> Assignee: rajeshbabu
> Fix For: 0.96.0, 0.94.1, 0.92.3
>
> Attachments: HBASE-6229_94.patch, HBASE-6229_94_1.patch, HBASE-6229_trunk.patch, HBASE-6229_trunk_1.patch
>
>
> In case of assign from EnableTableHandler table state is ENABLING. Any how EnableTableHandler will set ENABLED after assigning all the the table regions. If we try to set to ENABLED directly then client api may think ENABLE table is completed. When we have a case like all the regions are added directly into META and we call assignRegion then we need to make the table ENABLED. Hence in such case the table will not be in ENABLING or ENABLED state.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6229) AM.assign() should not set table
state to ENABLED directly.
Posted by "rajeshbabu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
rajeshbabu updated HBASE-6229:
------------------------------
Status: Patch Available (was: Open)
> AM.assign() should not set table state to ENABLED directly.
> -----------------------------------------------------------
>
> Key: HBASE-6229
> URL: https://issues.apache.org/jira/browse/HBASE-6229
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.2, 0.94.1
> Reporter: rajeshbabu
> Assignee: rajeshbabu
> Fix For: 0.96.0, 0.94.1, 0.92.3
>
> Attachments: HBASE-6229_94.patch, HBASE-6229_94_1.patch, HBASE-6229_trunk.patch, HBASE-6229_trunk_1.patch
>
>
> In case of assign from EnableTableHandler table state is ENABLING. Any how EnableTableHandler will set ENABLED after assigning all the the table regions. If we try to set to ENABLED directly then client api may think ENABLE table is completed. When we have a case like all the regions are added directly into META and we call assignRegion then we need to make the table ENABLED. Hence in such case the table will not be in ENABLING or ENABLED state.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6229) AM.assign() should not set table
state to ENABLED directly.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13397874#comment-13397874 ]
Hudson commented on HBASE-6229:
-------------------------------
Integrated in HBase-TRUNK #3050 (See [https://builds.apache.org/job/HBase-TRUNK/3050/])
HBASE-6229 AM.assign() should not set table state to ENABLED directly (Rajesh) (Revision 1352262)
Result = FAILURE
tedyu :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
> AM.assign() should not set table state to ENABLED directly.
> -----------------------------------------------------------
>
> Key: HBASE-6229
> URL: https://issues.apache.org/jira/browse/HBASE-6229
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.2, 0.94.1
> Reporter: rajeshbabu
> Assignee: rajeshbabu
> Fix For: 0.96.0, 0.94.1, 0.92.3
>
> Attachments: 6229_trunk_2.patch, HBASE-6229_94.patch, HBASE-6229_94_1.patch, HBASE-6229_94_2.patch, HBASE-6229_trunk.patch, HBASE-6229_trunk_1.patch
>
>
> In case of assign from EnableTableHandler table state is ENABLING. Any how EnableTableHandler will set ENABLED after assigning all the the table regions. If we try to set to ENABLED directly then client api may think ENABLE table is completed. When we have a case like all the regions are added directly into META and we call assignRegion then we need to make the table ENABLED. Hence in such case the table will not be in ENABLING or ENABLED state.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6229) AM.assign() should not set table
state to ENABLED directly.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13397260#comment-13397260 ]
Hadoop QA commented on HBASE-6229:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12532639/6229_trunk_2.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 7 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.util.TestHBaseFsck
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2195//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2195//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2195//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2195//console
This message is automatically generated.
> AM.assign() should not set table state to ENABLED directly.
> -----------------------------------------------------------
>
> Key: HBASE-6229
> URL: https://issues.apache.org/jira/browse/HBASE-6229
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.2, 0.94.1
> Reporter: rajeshbabu
> Assignee: rajeshbabu
> Fix For: 0.96.0, 0.94.1, 0.92.3
>
> Attachments: 6229_trunk_2.patch, HBASE-6229_94.patch, HBASE-6229_94_1.patch, HBASE-6229_94_2.patch, HBASE-6229_trunk.patch, HBASE-6229_trunk_1.patch
>
>
> In case of assign from EnableTableHandler table state is ENABLING. Any how EnableTableHandler will set ENABLED after assigning all the the table regions. If we try to set to ENABLED directly then client api may think ENABLE table is completed. When we have a case like all the regions are added directly into META and we call assignRegion then we need to make the table ENABLED. Hence in such case the table will not be in ENABLING or ENABLED state.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6229) AM.assign() should not set table
state to ENABLED directly.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13397821#comment-13397821 ]
Hudson commented on HBASE-6229:
-------------------------------
Integrated in HBase-0.94 #264 (See [https://builds.apache.org/job/HBase-0.94/264/])
HBASE-6229 AM.assign() should not set table state to ENABLED directly (Rajesh) (Revision 1352263)
Result = SUCCESS
tedyu :
Files :
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
> AM.assign() should not set table state to ENABLED directly.
> -----------------------------------------------------------
>
> Key: HBASE-6229
> URL: https://issues.apache.org/jira/browse/HBASE-6229
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.2, 0.94.1
> Reporter: rajeshbabu
> Assignee: rajeshbabu
> Fix For: 0.96.0, 0.94.1, 0.92.3
>
> Attachments: 6229_trunk_2.patch, HBASE-6229_94.patch, HBASE-6229_94_1.patch, HBASE-6229_94_2.patch, HBASE-6229_trunk.patch, HBASE-6229_trunk_1.patch
>
>
> In case of assign from EnableTableHandler table state is ENABLING. Any how EnableTableHandler will set ENABLED after assigning all the the table regions. If we try to set to ENABLED directly then client api may think ENABLE table is completed. When we have a case like all the regions are added directly into META and we call assignRegion then we need to make the table ENABLED. Hence in such case the table will not be in ENABLING or ENABLED state.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6229) AM.assign() should not set table
state to ENABLED directly.
Posted by "rajeshbabu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
rajeshbabu updated HBASE-6229:
------------------------------
Resolution: Fixed
Fix Version/s: (was: 0.92.3)
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
> AM.assign() should not set table state to ENABLED directly.
> -----------------------------------------------------------
>
> Key: HBASE-6229
> URL: https://issues.apache.org/jira/browse/HBASE-6229
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.2, 0.94.1
> Reporter: rajeshbabu
> Assignee: rajeshbabu
> Fix For: 0.96.0, 0.94.1
>
> Attachments: 6229_trunk_2.patch, HBASE-6229_94.patch, HBASE-6229_94_1.patch, HBASE-6229_94_2.patch, HBASE-6229_trunk.patch, HBASE-6229_trunk_1.patch
>
>
> In case of assign from EnableTableHandler table state is ENABLING. Any how EnableTableHandler will set ENABLED after assigning all the the table regions. If we try to set to ENABLED directly then client api may think ENABLE table is completed. When we have a case like all the regions are added directly into META and we call assignRegion then we need to make the table ENABLED. Hence in such case the table will not be in ENABLING or ENABLED state.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6229) AM.assign() should not set table
state to ENABLED directly.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13395991#comment-13395991 ]
Hadoop QA commented on HBASE-6229:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12532417/HBASE-6229_trunk.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 7 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.client.TestFromClientSide
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2183//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2183//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2183//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2183//console
This message is automatically generated.
> AM.assign() should not set table state to ENABLED directly.
> -----------------------------------------------------------
>
> Key: HBASE-6229
> URL: https://issues.apache.org/jira/browse/HBASE-6229
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.2, 0.94.1
> Reporter: rajeshbabu
> Assignee: rajeshbabu
> Fix For: 0.96.0, 0.94.1, 0.92.3
>
> Attachments: HBASE-6229_94.patch, HBASE-6229_trunk.patch
>
>
> In case of assign from EnableTableHandler table state is ENABLING. Any how EnableTableHandler will set ENABLED after assigning all the the table regions. If we try to set to ENABLED directly then client api may think ENABLE table is completed. When we have a case like all the regions are added directly into META and we call assignRegion then we need to make the table ENABLED. Hence in such case the table will not be in ENABLING or ENABLED state.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6229) AM.assign() should not set table
state to ENABLED directly.
Posted by "Laxman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13396629#comment-13396629 ]
Laxman commented on HBASE-6229:
-------------------------------
small nit
{code}
+ private boolean isNotEnabledorEnablingTable(final String tableName) {
+ return !zkTable.isEnablingTable(tableName) && !zkTable.isEnabledTable(tableName);
+ }
{code}
A separate method method may not be required for one liner.
> AM.assign() should not set table state to ENABLED directly.
> -----------------------------------------------------------
>
> Key: HBASE-6229
> URL: https://issues.apache.org/jira/browse/HBASE-6229
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.2, 0.94.1
> Reporter: rajeshbabu
> Assignee: rajeshbabu
> Fix For: 0.96.0, 0.94.1, 0.92.3
>
> Attachments: HBASE-6229_94.patch, HBASE-6229_94_1.patch, HBASE-6229_trunk.patch, HBASE-6229_trunk_1.patch
>
>
> In case of assign from EnableTableHandler table state is ENABLING. Any how EnableTableHandler will set ENABLED after assigning all the the table regions. If we try to set to ENABLED directly then client api may think ENABLE table is completed. When we have a case like all the regions are added directly into META and we call assignRegion then we need to make the table ENABLED. Hence in such case the table will not be in ENABLING or ENABLED state.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6229) AM.assign() should not set table
state to ENABLED directly.
Posted by "rajeshbabu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
rajeshbabu updated HBASE-6229:
------------------------------
Attachment: HBASE-6229_94_2.patch
> AM.assign() should not set table state to ENABLED directly.
> -----------------------------------------------------------
>
> Key: HBASE-6229
> URL: https://issues.apache.org/jira/browse/HBASE-6229
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.2, 0.94.1
> Reporter: rajeshbabu
> Assignee: rajeshbabu
> Fix For: 0.96.0, 0.94.1, 0.92.3
>
> Attachments: 6229_trunk_2.patch, HBASE-6229_94.patch, HBASE-6229_94_1.patch, HBASE-6229_94_2.patch, HBASE-6229_trunk.patch, HBASE-6229_trunk_1.patch
>
>
> In case of assign from EnableTableHandler table state is ENABLING. Any how EnableTableHandler will set ENABLED after assigning all the the table regions. If we try to set to ENABLED directly then client api may think ENABLE table is completed. When we have a case like all the regions are added directly into META and we call assignRegion then we need to make the table ENABLED. Hence in such case the table will not be in ENABLING or ENABLED state.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6229) AM.assign() should not set table
state to ENABLED directly.
Posted by "rajeshbabu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13397257#comment-13397257 ]
rajeshbabu commented on HBASE-6229:
-----------------------------------
Updated patch for 94. Thanks Ted.
> AM.assign() should not set table state to ENABLED directly.
> -----------------------------------------------------------
>
> Key: HBASE-6229
> URL: https://issues.apache.org/jira/browse/HBASE-6229
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.2, 0.94.1
> Reporter: rajeshbabu
> Assignee: rajeshbabu
> Fix For: 0.96.0, 0.94.1, 0.92.3
>
> Attachments: 6229_trunk_2.patch, HBASE-6229_94.patch, HBASE-6229_94_1.patch, HBASE-6229_94_2.patch, HBASE-6229_trunk.patch, HBASE-6229_trunk_1.patch
>
>
> In case of assign from EnableTableHandler table state is ENABLING. Any how EnableTableHandler will set ENABLED after assigning all the the table regions. If we try to set to ENABLED directly then client api may think ENABLE table is completed. When we have a case like all the regions are added directly into META and we call assignRegion then we need to make the table ENABLED. Hence in such case the table will not be in ENABLING or ENABLED state.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6229) AM.assign() should not set table
state to ENABLED directly.
Posted by "rajeshbabu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13396603#comment-13396603 ]
rajeshbabu commented on HBASE-6229:
-----------------------------------
Please refer to the latest.
> AM.assign() should not set table state to ENABLED directly.
> -----------------------------------------------------------
>
> Key: HBASE-6229
> URL: https://issues.apache.org/jira/browse/HBASE-6229
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.2, 0.94.1
> Reporter: rajeshbabu
> Assignee: rajeshbabu
> Fix For: 0.96.0, 0.94.1, 0.92.3
>
> Attachments: HBASE-6229_94.patch, HBASE-6229_94_1.patch, HBASE-6229_trunk.patch, HBASE-6229_trunk_1.patch
>
>
> In case of assign from EnableTableHandler table state is ENABLING. Any how EnableTableHandler will set ENABLED after assigning all the the table regions. If we try to set to ENABLED directly then client api may think ENABLE table is completed. When we have a case like all the regions are added directly into META and we call assignRegion then we need to make the table ENABLED. Hence in such case the table will not be in ENABLING or ENABLED state.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6229) AM.assign() should not set table
state to ENABLED directly.
Posted by "rajeshbabu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
rajeshbabu updated HBASE-6229:
------------------------------
Attachment: HBASE-6229_94.patch
> AM.assign() should not set table state to ENABLED directly.
> -----------------------------------------------------------
>
> Key: HBASE-6229
> URL: https://issues.apache.org/jira/browse/HBASE-6229
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.2, 0.94.1
> Reporter: rajeshbabu
> Assignee: rajeshbabu
> Fix For: 0.96.0, 0.94.1, 0.92.3
>
> Attachments: HBASE-6229_94.patch, HBASE-6229_trunk.patch
>
>
> In case of assign from EnableTableHandler table state is ENABLING. Any how EnableTableHandler will set ENABLED after assigning all the the table regions. If we try to set to ENABLED directly then client api may think ENABLE table is completed. When we have a case like all the regions are added directly into META and we call assignRegion then we need to make the table ENABLED. Hence in such case the table will not be in ENABLING or ENABLED state.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6229) AM.assign() should not set table
state to ENABLED directly.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400017#comment-13400017 ]
Hudson commented on HBASE-6229:
-------------------------------
Integrated in HBase-0.94-security #37 (See [https://builds.apache.org/job/HBase-0.94-security/37/])
HBASE-6229 AM.assign() should not set table state to ENABLED directly (Rajesh) (Revision 1352263)
Result = SUCCESS
tedyu :
Files :
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
> AM.assign() should not set table state to ENABLED directly.
> -----------------------------------------------------------
>
> Key: HBASE-6229
> URL: https://issues.apache.org/jira/browse/HBASE-6229
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.2, 0.94.1
> Reporter: rajeshbabu
> Assignee: rajeshbabu
> Fix For: 0.96.0, 0.94.1, 0.92.3
>
> Attachments: 6229_trunk_2.patch, HBASE-6229_94.patch, HBASE-6229_94_1.patch, HBASE-6229_94_2.patch, HBASE-6229_trunk.patch, HBASE-6229_trunk_1.patch
>
>
> In case of assign from EnableTableHandler table state is ENABLING. Any how EnableTableHandler will set ENABLED after assigning all the the table regions. If we try to set to ENABLED directly then client api may think ENABLE table is completed. When we have a case like all the regions are added directly into META and we call assignRegion then we need to make the table ENABLED. Hence in such case the table will not be in ENABLING or ENABLED state.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6229) AM.assign() should not set table
state to ENABLED directly.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13397261#comment-13397261 ]
Hadoop QA commented on HBASE-6229:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12532644/HBASE-6229_94_2.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2196//console
This message is automatically generated.
> AM.assign() should not set table state to ENABLED directly.
> -----------------------------------------------------------
>
> Key: HBASE-6229
> URL: https://issues.apache.org/jira/browse/HBASE-6229
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.2, 0.94.1
> Reporter: rajeshbabu
> Assignee: rajeshbabu
> Fix For: 0.96.0, 0.94.1, 0.92.3
>
> Attachments: 6229_trunk_2.patch, HBASE-6229_94.patch, HBASE-6229_94_1.patch, HBASE-6229_94_2.patch, HBASE-6229_trunk.patch, HBASE-6229_trunk_1.patch
>
>
> In case of assign from EnableTableHandler table state is ENABLING. Any how EnableTableHandler will set ENABLED after assigning all the the table regions. If we try to set to ENABLED directly then client api may think ENABLE table is completed. When we have a case like all the regions are added directly into META and we call assignRegion then we need to make the table ENABLED. Hence in such case the table will not be in ENABLING or ENABLED state.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6229) AM.assign() should not set table
state to ENABLED directly.
Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Ted Yu updated HBASE-6229:
----------------------------------
Attachment: 6229_trunk_2.patch
Patch v2 I plan to integrate.
> AM.assign() should not set table state to ENABLED directly.
> -----------------------------------------------------------
>
> Key: HBASE-6229
> URL: https://issues.apache.org/jira/browse/HBASE-6229
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.2, 0.94.1
> Reporter: rajeshbabu
> Assignee: rajeshbabu
> Fix For: 0.96.0, 0.94.1, 0.92.3
>
> Attachments: 6229_trunk_2.patch, HBASE-6229_94.patch, HBASE-6229_94_1.patch, HBASE-6229_trunk.patch, HBASE-6229_trunk_1.patch
>
>
> In case of assign from EnableTableHandler table state is ENABLING. Any how EnableTableHandler will set ENABLED after assigning all the the table regions. If we try to set to ENABLED directly then client api may think ENABLE table is completed. When we have a case like all the regions are added directly into META and we call assignRegion then we need to make the table ENABLED. Hence in such case the table will not be in ENABLING or ENABLED state.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6229) AM.assign() should not set table
state to ENABLED directly.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13396620#comment-13396620 ]
Hadoop QA commented on HBASE-6229:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12532516/HBASE-6229_trunk_1.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 7 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.replication.TestReplication
org.apache.hadoop.hbase.client.TestAdmin
org.apache.hadoop.hbase.io.hfile.TestForceCacheImportantBlocks
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2189//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2189//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2189//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2189//console
This message is automatically generated.
> AM.assign() should not set table state to ENABLED directly.
> -----------------------------------------------------------
>
> Key: HBASE-6229
> URL: https://issues.apache.org/jira/browse/HBASE-6229
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.2, 0.94.1
> Reporter: rajeshbabu
> Assignee: rajeshbabu
> Fix For: 0.96.0, 0.94.1, 0.92.3
>
> Attachments: HBASE-6229_94.patch, HBASE-6229_94_1.patch, HBASE-6229_trunk.patch, HBASE-6229_trunk_1.patch
>
>
> In case of assign from EnableTableHandler table state is ENABLING. Any how EnableTableHandler will set ENABLED after assigning all the the table regions. If we try to set to ENABLED directly then client api may think ENABLE table is completed. When we have a case like all the regions are added directly into META and we call assignRegion then we need to make the table ENABLED. Hence in such case the table will not be in ENABLING or ENABLED state.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6229) AM.assign() should not set table
state to ENABLED directly.
Posted by "rajeshbabu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
rajeshbabu updated HBASE-6229:
------------------------------
Attachment: HBASE-6229_trunk_1.patch
> AM.assign() should not set table state to ENABLED directly.
> -----------------------------------------------------------
>
> Key: HBASE-6229
> URL: https://issues.apache.org/jira/browse/HBASE-6229
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.2, 0.94.1
> Reporter: rajeshbabu
> Assignee: rajeshbabu
> Fix For: 0.96.0, 0.94.1, 0.92.3
>
> Attachments: HBASE-6229_94.patch, HBASE-6229_94_1.patch, HBASE-6229_trunk.patch, HBASE-6229_trunk_1.patch
>
>
> In case of assign from EnableTableHandler table state is ENABLING. Any how EnableTableHandler will set ENABLED after assigning all the the table regions. If we try to set to ENABLED directly then client api may think ENABLE table is completed. When we have a case like all the regions are added directly into META and we call assignRegion then we need to make the table ENABLED. Hence in such case the table will not be in ENABLING or ENABLED state.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6229) AM.assign() should not set table
state to ENABLED directly.
Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398741#comment-13398741 ]
ramkrishna.s.vasudevan commented on HBASE-6229:
-----------------------------------------------
@Ted
This change is not applicable in 0.92. As HBASE-5206 is not committed to 0.92
> AM.assign() should not set table state to ENABLED directly.
> -----------------------------------------------------------
>
> Key: HBASE-6229
> URL: https://issues.apache.org/jira/browse/HBASE-6229
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.2, 0.94.1
> Reporter: rajeshbabu
> Assignee: rajeshbabu
> Fix For: 0.96.0, 0.94.1, 0.92.3
>
> Attachments: 6229_trunk_2.patch, HBASE-6229_94.patch, HBASE-6229_94_1.patch, HBASE-6229_94_2.patch, HBASE-6229_trunk.patch, HBASE-6229_trunk_1.patch
>
>
> In case of assign from EnableTableHandler table state is ENABLING. Any how EnableTableHandler will set ENABLED after assigning all the the table regions. If we try to set to ENABLED directly then client api may think ENABLE table is completed. When we have a case like all the regions are added directly into META and we call assignRegion then we need to make the table ENABLED. Hence in such case the table will not be in ENABLING or ENABLED state.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6229) AM.assign() should not set table
state to ENABLED directly.
Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13397244#comment-13397244 ]
ramkrishna.s.vasudevan commented on HBASE-6229:
-----------------------------------------------
+1 Ted. Thanks for making the change. We were about to upload one.
> AM.assign() should not set table state to ENABLED directly.
> -----------------------------------------------------------
>
> Key: HBASE-6229
> URL: https://issues.apache.org/jira/browse/HBASE-6229
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.2, 0.94.1
> Reporter: rajeshbabu
> Assignee: rajeshbabu
> Fix For: 0.96.0, 0.94.1, 0.92.3
>
> Attachments: 6229_trunk_2.patch, HBASE-6229_94.patch, HBASE-6229_94_1.patch, HBASE-6229_trunk.patch, HBASE-6229_trunk_1.patch
>
>
> In case of assign from EnableTableHandler table state is ENABLING. Any how EnableTableHandler will set ENABLED after assigning all the the table regions. If we try to set to ENABLED directly then client api may think ENABLE table is completed. When we have a case like all the regions are added directly into META and we call assignRegion then we need to make the table ENABLED. Hence in such case the table will not be in ENABLING or ENABLED state.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6229) AM.assign() should not set table
state to ENABLED directly.
Posted by "rajeshbabu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
rajeshbabu updated HBASE-6229:
------------------------------
Attachment: HBASE-6229_94_1.patch
> AM.assign() should not set table state to ENABLED directly.
> -----------------------------------------------------------
>
> Key: HBASE-6229
> URL: https://issues.apache.org/jira/browse/HBASE-6229
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.2, 0.94.1
> Reporter: rajeshbabu
> Assignee: rajeshbabu
> Fix For: 0.96.0, 0.94.1, 0.92.3
>
> Attachments: HBASE-6229_94.patch, HBASE-6229_94_1.patch, HBASE-6229_trunk.patch, HBASE-6229_trunk_1.patch
>
>
> In case of assign from EnableTableHandler table state is ENABLING. Any how EnableTableHandler will set ENABLED after assigning all the the table regions. If we try to set to ENABLED directly then client api may think ENABLE table is completed. When we have a case like all the regions are added directly into META and we call assignRegion then we need to make the table ENABLED. Hence in such case the table will not be in ENABLING or ENABLED state.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6229) AM.assign() should not set table
state to ENABLED directly.
Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13397774#comment-13397774 ]
Zhihong Ted Yu commented on HBASE-6229:
---------------------------------------
I ran TestHBaseFsck manually with patch v2 and it passed.
{code}
Running org.apache.hadoop.hbase.util.TestHBaseFsck
Tests run: 19, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 243.228 sec
Results :
Tests run: 19, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] --- maven-surefire-plugin:2.10:test (secondPartTestsExecution) @ hbase-server ---
[INFO] Tests are skipped.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 4:28.120s
{code}
> AM.assign() should not set table state to ENABLED directly.
> -----------------------------------------------------------
>
> Key: HBASE-6229
> URL: https://issues.apache.org/jira/browse/HBASE-6229
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.2, 0.94.1
> Reporter: rajeshbabu
> Assignee: rajeshbabu
> Fix For: 0.96.0, 0.94.1, 0.92.3
>
> Attachments: 6229_trunk_2.patch, HBASE-6229_94.patch, HBASE-6229_94_1.patch, HBASE-6229_94_2.patch, HBASE-6229_trunk.patch, HBASE-6229_trunk_1.patch
>
>
> In case of assign from EnableTableHandler table state is ENABLING. Any how EnableTableHandler will set ENABLED after assigning all the the table regions. If we try to set to ENABLED directly then client api may think ENABLE table is completed. When we have a case like all the regions are added directly into META and we call assignRegion then we need to make the table ENABLED. Hence in such case the table will not be in ENABLING or ENABLED state.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6229) AM.assign() should not set table
state to ENABLED directly.
Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13397761#comment-13397761 ]
Zhihong Ted Yu commented on HBASE-6229:
---------------------------------------
Integrated to 0.94 and trunk.
Thanks for the patch, Rajesh.
Thanks for the review Laxman and Ram.
> AM.assign() should not set table state to ENABLED directly.
> -----------------------------------------------------------
>
> Key: HBASE-6229
> URL: https://issues.apache.org/jira/browse/HBASE-6229
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.2, 0.94.1
> Reporter: rajeshbabu
> Assignee: rajeshbabu
> Fix For: 0.96.0, 0.94.1, 0.92.3
>
> Attachments: 6229_trunk_2.patch, HBASE-6229_94.patch, HBASE-6229_94_1.patch, HBASE-6229_94_2.patch, HBASE-6229_trunk.patch, HBASE-6229_trunk_1.patch
>
>
> In case of assign from EnableTableHandler table state is ENABLING. Any how EnableTableHandler will set ENABLED after assigning all the the table regions. If we try to set to ENABLED directly then client api may think ENABLE table is completed. When we have a case like all the regions are added directly into META and we call assignRegion then we need to make the table ENABLED. Hence in such case the table will not be in ENABLING or ENABLED state.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (HBASE-6229) AM.assign() should not set table state
to ENABLED directly.
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl closed HBASE-6229.
--------------------------------
> AM.assign() should not set table state to ENABLED directly.
> -----------------------------------------------------------
>
> Key: HBASE-6229
> URL: https://issues.apache.org/jira/browse/HBASE-6229
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.2, 0.94.1
> Reporter: rajeshbabu
> Assignee: rajeshbabu
> Fix For: 0.94.1, 0.96.0
>
> Attachments: 6229_trunk_2.patch, HBASE-6229_94_1.patch, HBASE-6229_94_2.patch, HBASE-6229_94.patch, HBASE-6229_trunk_1.patch, HBASE-6229_trunk.patch
>
>
> In case of assign from EnableTableHandler table state is ENABLING. Any how EnableTableHandler will set ENABLED after assigning all the the table regions. If we try to set to ENABLED directly then client api may think ENABLE table is completed. When we have a case like all the regions are added directly into META and we call assignRegion then we need to make the table ENABLED. Hence in such case the table will not be in ENABLING or ENABLED state.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira