You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2019/04/29 14:19:20 UTC
[kudu-CR] [backup] Hide scanLeaderOnly option
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13172
Change subject: [backup] Hide scanLeaderOnly option
......................................................................
[backup] Hide scanLeaderOnly option
Marks the scanLeaderOnly option as hidden given
we don’t expect it to be used in the common case.
Change-Id: Ia4cdd1ec95fee09de248452bce198682b4d150dd
---
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/Options.scala
M java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestOptions.scala
2 files changed, 7 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/72/13172/1
--
To view, visit http://gerrit.cloudera.org:8080/13172
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia4cdd1ec95fee09de248452bce198682b4d150dd
Gerrit-Change-Number: 13172
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [backup] Hide scanLeaderOnly option
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13172 )
Change subject: [backup] Hide scanLeaderOnly option
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/13172
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4cdd1ec95fee09de248452bce198682b4d150dd
Gerrit-Change-Number: 13172
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Mon, 29 Apr 2019 22:19:25 +0000
Gerrit-HasComments: No
[kudu-CR] [backup] Hide scanLeaderOnly option
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13172 )
Change subject: [backup] Hide scanLeaderOnly option
......................................................................
[backup] Hide scanLeaderOnly option
Marks the scanLeaderOnly option as hidden given
we don’t expect it to be used in the common case.
Change-Id: Ia4cdd1ec95fee09de248452bce198682b4d150dd
Reviewed-on: http://gerrit.cloudera.org:8080/13172
Tested-by: Kudu Jenkins
Reviewed-by: Mike Percy <mp...@apache.org>
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/Options.scala
M java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestOptions.scala
2 files changed, 7 insertions(+), 8 deletions(-)
Approvals:
Kudu Jenkins: Verified
Mike Percy: Looks good to me, approved
Adar Dembo: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.cloudera.org:8080/13172
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia4cdd1ec95fee09de248452bce198682b4d150dd
Gerrit-Change-Number: 13172
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] [backup] Hide scanLeaderOnly option
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13172 )
Change subject: [backup] Hide scanLeaderOnly option
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13172
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4cdd1ec95fee09de248452bce198682b4d150dd
Gerrit-Change-Number: 13172
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Mon, 29 Apr 2019 19:42:18 +0000
Gerrit-HasComments: No