[jira] [Comment Edited] (YARN-8805) Automatically convert the launch command to the exec form when using entrypoint support

["Eric Yang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16782097#comment-16782097 ] 

Eric Yang edited comment on YARN-8805 at 3/1/19 9:34 PM:
---------------------------------------------------------

[~ebadger] The white space behavior supports parameters with spacing inside double quote.
This mimics shell generating exec parameters in limited fashion, for example:

{code}
ls -l  "/Users/john smith"
{code}

The receiving program will have exec form as:

{code}
ls,-l,/Users/john smith
{code}

Bash stripped the double quotes during shell expansion, and not actually passed as static string to argv.  The current patch copies that behavior, but it doesn't do real shell expansion for environment variables.




was (Author: eyang):
[~ebadger] The white space behavior supports parameters with spacing inside double quote.
This mimics shell generating exec parameters in limited fashion, for example:

{code}
ls -l  "/Users/john smith"
{code}

The receiving program will have exec form as:

{code}
ls,-l,/Users/john smith
{code}

The double quotes is stripped during shell expansion, and not actually passed as static string to argv.



> Automatically convert the launch command to the exec form when using entrypoint support
> ---------------------------------------------------------------------------------------
>
>                 Key: YARN-8805
>                 URL: https://issues.apache.org/jira/browse/YARN-8805
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Shane Kumpf
>            Assignee: Eric Yang
>            Priority: Major
>              Labels: Docker
>         Attachments: YARN-8805.001.patch, YARN-8805.004.patch, YARN-8805.005.patch
>
>
> When {{YARN_CONTAINER_RUNTIME_DOCKER_RUN_OVERRIDE_DISABLE}} is true, and a launch command is provided, it is expected that the launch command is provided by the user in exec form.
> For example:
> {code:java}
> "/usr/bin/sleep 6000"{code}
> must be changed to:
> {code}"/usr/bin/sleep,6000"{code}
> If this is not done, the container will never start and will be in a Created state. We should automatically do this conversion vs making the user understand this nuance of using the entrypoint support. Docs should be updated to reflect this change.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org