You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by maropu <gi...@git.apache.org> on 2018/07/12 05:47:43 UTC

[GitHub] spark pull request #21752: [SPARK-24788][SQL] fixed UnresolvedException when...

Github user maropu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21752#discussion_r201915580
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala ---
    @@ -717,4 +717,9 @@ class DataFrameAggregateSuite extends QueryTest with SharedSQLContext {
           Row(1, 2, 1) :: Row(2, 2, 2) :: Row(3, 2, 3) :: Nil)
       }
     
    +  test("SPARK-24788: RelationalGroupedDataset.toString " +
    +    "with unresolved grouping expressions should not throw an exception") {
    +    noException should be thrownBy testData.groupBy('key).toString
    +  }
    +
    --- End diff --
    
    nit: remove the blank line


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org