You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/04/01 22:38:21 UTC
[GitHub] [incubator-pinot] codecov-io commented on issue #4048: Make
SingleConnectionBrokerRequestHandler as default
codecov-io commented on issue #4048: Make SingleConnectionBrokerRequestHandler as default
URL: https://github.com/apache/incubator-pinot/pull/4048#issuecomment-478772627
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4048?src=pr&el=h1) Report
> Merging [#4048](https://codecov.io/gh/apache/incubator-pinot/pull/4048?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/202009f973d64670f2a480c2546e4a7bb8f06e8a?src=pr&el=desc) will **increase** coverage by `9.58%`.
> The diff coverage is `66.66%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-pinot/pull/4048/graphs/tree.svg?width=650&token=4ibza2ugkz&height=150&src=pr)](https://codecov.io/gh/apache/incubator-pinot/pull/4048?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4048 +/- ##
============================================
+ Coverage 57.07% 66.65% +9.58%
Complexity 20 20
============================================
Files 1033 1033
Lines 51388 51388
Branches 7196 7196
============================================
+ Hits 29329 34253 +4924
+ Misses 19880 14779 -5101
- Partials 2179 2356 +177
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4048?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/pinot/broker/broker/BrokerServerBuilder.java](https://codecov.io/gh/apache/incubator-pinot/pull/4048/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL0Jyb2tlclNlcnZlckJ1aWxkZXIuamF2YQ==) | `85.71% <66.66%> (+16.07%)` | `0 <0> (ø)` | :arrow_down: |
| [...ache/pinot/transport/conf/TransportClientConf.java](https://codecov.io/gh/apache/incubator-pinot/pull/4048/diff?src=pr&el=tree#diff-cGlub3QtdHJhbnNwb3J0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC90cmFuc3BvcnQvY29uZi9UcmFuc3BvcnRDbGllbnRDb25mLmphdmE=) | `0% <0%> (-66.67%)` | `0% <0%> (ø)` | |
| [...broker/broker/helix/LiveInstanceChangeHandler.java](https://codecov.io/gh/apache/incubator-pinot/pull/4048/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL2hlbGl4L0xpdmVJbnN0YW5jZUNoYW5nZUhhbmRsZXIuamF2YQ==) | `13.63% <0%> (-45.46%)` | `0% <0%> (ø)` | |
| [...e/pinot/transport/config/ConnectionPoolConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/4048/diff?src=pr&el=tree#diff-cGlub3QtdHJhbnNwb3J0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC90cmFuc3BvcnQvY29uZmlnL0Nvbm5lY3Rpb25Qb29sQ29uZmlnLmphdmE=) | `0% <0%> (-45%)` | `0% <0%> (ø)` | |
| [...pache/pinot/transport/config/ThreadPoolConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/4048/diff?src=pr&el=tree#diff-cGlub3QtdHJhbnNwb3J0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC90cmFuc3BvcnQvY29uZmlnL1RocmVhZFBvb2xDb25maWcuamF2YQ==) | `0% <0%> (-33.34%)` | `0% <0%> (ø)` | |
| [...che/pinot/transport/config/RoutingTableConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/4048/diff?src=pr&el=tree#diff-cGlub3QtdHJhbnNwb3J0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC90cmFuc3BvcnQvY29uZmlnL1JvdXRpbmdUYWJsZUNvbmZpZy5qYXZh) | `0% <0%> (-20%)` | `0% <0%> (ø)` | |
| [...esthandler/ConnectionPoolBrokerRequestHandler.java](https://codecov.io/gh/apache/incubator-pinot/pull/4048/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcmVxdWVzdGhhbmRsZXIvQ29ubmVjdGlvblBvb2xCcm9rZXJSZXF1ZXN0SGFuZGxlci5qYXZh) | `0% <0%> (-12.35%)` | `0% <0%> (ø)` | |
| [...org/apache/pinot/transport/pool/KeyedPoolImpl.java](https://codecov.io/gh/apache/incubator-pinot/pull/4048/diff?src=pr&el=tree#diff-cGlub3QtdHJhbnNwb3J0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC90cmFuc3BvcnQvcG9vbC9LZXllZFBvb2xJbXBsLmphdmE=) | `91.25% <0%> (-2.5%)` | `0% <0%> (ø)` | |
| [...inot/transport/netty/NettyTCPClientConnection.java](https://codecov.io/gh/apache/incubator-pinot/pull/4048/diff?src=pr&el=tree#diff-cGlub3QtdHJhbnNwb3J0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC90cmFuc3BvcnQvbmV0dHkvTmV0dHlUQ1BDbGllbnRDb25uZWN0aW9uLmphdmE=) | `81.45% <0%> (-0.67%)` | `0% <0%> (ø)` | |
| [...ator/transform/function/BaseTransformFunction.java](https://codecov.io/gh/apache/incubator-pinot/pull/4048/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci90cmFuc2Zvcm0vZnVuY3Rpb24vQmFzZVRyYW5zZm9ybUZ1bmN0aW9uLmphdmE=) | `29.95% <0%> (+0.42%)` | `0% <0%> (ø)` | :arrow_down: |
| ... and [328 more](https://codecov.io/gh/apache/incubator-pinot/pull/4048/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4048?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4048?src=pr&el=footer). Last update [202009f...7bcee13](https://codecov.io/gh/apache/incubator-pinot/pull/4048?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org