You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "blaginin (via GitHub)" <gi...@apache.org> on 2025/03/08 10:42:14 UTC
[I] Auto run docker containers needed for tests [datafusion]
blaginin opened a new issue, #15092:
URL: https://github.com/apache/datafusion/issues/15092
### Is your feature request related to a problem or challenge?
https://github.com/apache/datafusion/pull/13672 adds a new CLI integration testing with external storage tests, using Minio. Currently, running tests requires manually starting a Minio Docker container.
### Describe the solution you'd like
@findepi [suggests](https://github.com/apache/datafusion/pull/13672#pullrequestreview-2669043933) that we can automatically start the required containers
### Describe alternatives you've considered
_No response_
### Additional context
@findepi highlighted
> In Trino land this is done with testcontainers-java and it works awesomely well from developer experience perspective.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Auto run docker containers needed for tests [datafusion]
Posted by "blaginin (via GitHub)" <gi...@apache.org>.
blaginin closed issue #15092: Auto run docker containers needed for tests
URL: https://github.com/apache/datafusion/issues/15092
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Auto run docker containers needed for tests [datafusion]
Posted by "Omega359 (via GitHub)" <gi...@apache.org>.
Omega359 commented on issue #15092:
URL: https://github.com/apache/datafusion/issues/15092#issuecomment-2708932399
> I think [@Omega359](https://github.com/Omega359) did something similar here with sqllogictests for starting postgres:
>
> https://github.com/apache/datafusion/blob/main/datafusion/sqllogictest/bin/postgres_container.rs
>
> Perhaps we could use a similar approach for the minio one
In my tests I do start minio using the same pattern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Auto run docker containers needed for tests [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #15092:
URL: https://github.com/apache/datafusion/issues/15092#issuecomment-2708204616
I think @Omega359 did something similar here with sqllogictests for starting postgres:
https://github.com/apache/datafusion/blob/main/datafusion/sqllogictest/bin/postgres_container.rs
Perhaps we could use a similar approach for the minio one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org