You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joris Van Remoortere <jo...@gmail.com> on 2015/07/21 22:30:33 UTC

Review Request 36646: Added 'CONFIGURATION' flag to jenkins_build script.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36646/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman and Vinod Kone.


Bugs: MESOS-2963
    https://issues.apache.org/jira/browse/MESOS-2963


Repository: mesos


Description
-------

Also added libevent dependency to jenkins build.

In jenkins we can now provide 3 options for the `CONFIGURATION` environment variable that are: ` ` for the default build, `--enable-libevent` for libevent, and `--enable-libevent --enable-ssl` for SSL.


Diffs
-----

  support/jenkins_build.sh 7276fe28b558d96f90fc950b3ffad78573732eef 

Diff: https://reviews.apache.org/r/36646/diff/


Testing
-------

`OS="CENTOS" COMPILER="GCC" CONFIGURATION="--enable-libevent --enable-ssl" ./support/jenkins_build.sh`


Thanks,

Joris Van Remoortere

Re: Review Request 36646: Added 'CONFIGURATION' flag to jenkins_build script.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36646/#review92479
-----------------------------------------------------------


Patch looks great!

Reviews applied: [36646]

All tests passed.

- Mesos ReviewBot


On July 21, 2015, 8:30 p.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36646/
> -----------------------------------------------------------
> 
> (Updated July 21, 2015, 8:30 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Bugs: MESOS-2963
>     https://issues.apache.org/jira/browse/MESOS-2963
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Also added libevent dependency to jenkins build.
> 
> In jenkins we can now provide 3 options for the `CONFIGURATION` environment variable that are: ` ` for the default build, `--enable-libevent` for libevent, and `--enable-libevent --enable-ssl` for SSL.
> 
> 
> Diffs
> -----
> 
>   support/jenkins_build.sh 7276fe28b558d96f90fc950b3ffad78573732eef 
> 
> Diff: https://reviews.apache.org/r/36646/diff/
> 
> 
> Testing
> -------
> 
> `OS="CENTOS" COMPILER="GCC" CONFIGURATION="--enable-libevent --enable-ssl" ./support/jenkins_build.sh`
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 36646: Added 'CONFIGURATION' flag to jenkins_build script.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36646/#review93787
-----------------------------------------------------------

Ship it!


Ship It!

- Vinod Kone


On July 31, 2015, 9:02 p.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36646/
> -----------------------------------------------------------
> 
> (Updated July 31, 2015, 9:02 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Vinod Kone.
> 
> 
> Bugs: MESOS-2963 and MESOS-781
>     https://issues.apache.org/jira/browse/MESOS-2963
>     https://issues.apache.org/jira/browse/MESOS-781
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Also added libevent dependency to jenkins build.
> 
> In jenkins we can now provide 3 options for the `CONFIGURATION` environment variable that are: ` ` for the default build, `--enable-libevent` for libevent, and `--enable-libevent --enable-ssl` for SSL.
> 
> 
> Diffs
> -----
> 
>   support/jenkins_build.sh 7276fe28b558d96f90fc950b3ffad78573732eef 
> 
> Diff: https://reviews.apache.org/r/36646/diff/
> 
> 
> Testing
> -------
> 
> `OS="centos:7" COMPILER="gcc" CONFIGURATION="--enable-libevent --enable-ssl" support/jenkins_build.sh`
> `OS="ubuntu:14.10" COMPILER="gcc" CONFIGURATION="--enable-libevent --enable-ssl" support/jenkins_build.sh`
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 36646: Added 'CONFIGURATION' flag to jenkins_build script.

Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36646/
-----------------------------------------------------------

(Updated July 31, 2015, 9:02 p.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Vinod Kone.


Bugs: MESOS-2963 and MESOS-781
    https://issues.apache.org/jira/browse/MESOS-2963
    https://issues.apache.org/jira/browse/MESOS-781


Repository: mesos


Description
-------

Also added libevent dependency to jenkins build.

In jenkins we can now provide 3 options for the `CONFIGURATION` environment variable that are: ` ` for the default build, `--enable-libevent` for libevent, and `--enable-libevent --enable-ssl` for SSL.


Diffs
-----

  support/jenkins_build.sh 7276fe28b558d96f90fc950b3ffad78573732eef 

Diff: https://reviews.apache.org/r/36646/diff/


Testing (updated)
-------

`OS="centos:7" COMPILER="gcc" CONFIGURATION="--enable-libevent --enable-ssl" support/jenkins_build.sh`
`OS="ubuntu:14.10" COMPILER="gcc" CONFIGURATION="--enable-libevent --enable-ssl" support/jenkins_build.sh`


Thanks,

Joris Van Remoortere

Re: Review Request 36646: Added 'CONFIGURATION' flag to jenkins_build script.

Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36646/
-----------------------------------------------------------

(Updated July 31, 2015, 8:55 p.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Vinod Kone.


Bugs: MESOS-2963 and MESOS-781
    https://issues.apache.org/jira/browse/MESOS-2963
    https://issues.apache.org/jira/browse/MESOS-781


Repository: mesos


Description
-------

Also added libevent dependency to jenkins build.

In jenkins we can now provide 3 options for the `CONFIGURATION` environment variable that are: ` ` for the default build, `--enable-libevent` for libevent, and `--enable-libevent --enable-ssl` for SSL.


Diffs
-----

  support/jenkins_build.sh 7276fe28b558d96f90fc950b3ffad78573732eef 

Diff: https://reviews.apache.org/r/36646/diff/


Testing
-------

`OS="CENTOS" COMPILER="GCC" CONFIGURATION="--enable-libevent --enable-ssl" ./support/jenkins_build.sh`


Thanks,

Joris Van Remoortere

Re: Review Request 36646: Added 'CONFIGURATION' flag to jenkins_build script.

Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36646/
-----------------------------------------------------------

(Updated July 31, 2015, 8:54 p.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Vinod Kone.


Changes
-------

Used `DISTCHECK_CONFIGURE_FLAGS` to pass flags to make distcheck


Bugs: MESOS-2963 and MESOS-781
    https://issues.apache.org/jira/browse/MESOS-2963
    https://issues.apache.org/jira/browse/MESOS-781


Repository: mesos


Description
-------

Also added libevent dependency to jenkins build.

In jenkins we can now provide 3 options for the `CONFIGURATION` environment variable that are: ` ` for the default build, `--enable-libevent` for libevent, and `--enable-libevent --enable-ssl` for SSL.


Diffs (updated)
-----

  support/jenkins_build.sh 7276fe28b558d96f90fc950b3ffad78573732eef 

Diff: https://reviews.apache.org/r/36646/diff/


Testing
-------

`OS="CENTOS" COMPILER="GCC" CONFIGURATION="--enable-libevent --enable-ssl" ./support/jenkins_build.sh`


Thanks,

Joris Van Remoortere

Re: Review Request 36646: Added 'CONFIGURATION' flag to jenkins_build script.

Posted by Joris Van Remoortere <jo...@gmail.com>.

> On July 21, 2015, 9:17 p.m., Vinod Kone wrote:
> > did you also test with ubuntu?
> 
> Vinod Kone wrote:
>     any updates on this?

Sorry this took a while. It turned out I needed a solution to MESOS-781 to get this to work correctly.
I ran the test with: 
`OS="centos:7" COMPILER="gcc" CONFIGURATION="--enable-libevent --enable-ssl" support/jenkins_build.sh`
`OS="ubuntu:14.10" COMPILER="gcc" CONFIGURATION="--enable-libevent --enable-ssl" support/jenkins_build.sh`
The ssl dependencies were already installed on ubuntu:14.10 so I did not need to augment it.


- Joris


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36646/#review92478
-----------------------------------------------------------


On July 31, 2015, 8:55 p.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36646/
> -----------------------------------------------------------
> 
> (Updated July 31, 2015, 8:55 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Vinod Kone.
> 
> 
> Bugs: MESOS-2963 and MESOS-781
>     https://issues.apache.org/jira/browse/MESOS-2963
>     https://issues.apache.org/jira/browse/MESOS-781
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Also added libevent dependency to jenkins build.
> 
> In jenkins we can now provide 3 options for the `CONFIGURATION` environment variable that are: ` ` for the default build, `--enable-libevent` for libevent, and `--enable-libevent --enable-ssl` for SSL.
> 
> 
> Diffs
> -----
> 
>   support/jenkins_build.sh 7276fe28b558d96f90fc950b3ffad78573732eef 
> 
> Diff: https://reviews.apache.org/r/36646/diff/
> 
> 
> Testing
> -------
> 
> `OS="CENTOS" COMPILER="GCC" CONFIGURATION="--enable-libevent --enable-ssl" ./support/jenkins_build.sh`
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 36646: Added 'CONFIGURATION' flag to jenkins_build script.

Posted by Vinod Kone <vi...@gmail.com>.

> On July 21, 2015, 9:17 p.m., Vinod Kone wrote:
> > did you also test with ubuntu?

any updates on this?


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36646/#review92478
-----------------------------------------------------------


On July 21, 2015, 8:30 p.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36646/
> -----------------------------------------------------------
> 
> (Updated July 21, 2015, 8:30 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Bugs: MESOS-2963
>     https://issues.apache.org/jira/browse/MESOS-2963
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Also added libevent dependency to jenkins build.
> 
> In jenkins we can now provide 3 options for the `CONFIGURATION` environment variable that are: ` ` for the default build, `--enable-libevent` for libevent, and `--enable-libevent --enable-ssl` for SSL.
> 
> 
> Diffs
> -----
> 
>   support/jenkins_build.sh 7276fe28b558d96f90fc950b3ffad78573732eef 
> 
> Diff: https://reviews.apache.org/r/36646/diff/
> 
> 
> Testing
> -------
> 
> `OS="CENTOS" COMPILER="GCC" CONFIGURATION="--enable-libevent --enable-ssl" ./support/jenkins_build.sh`
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 36646: Added 'CONFIGURATION' flag to jenkins_build script.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36646/#review92478
-----------------------------------------------------------


did you also test with ubuntu?


support/jenkins_build.sh (line 57)
<https://reviews.apache.org/r/36646/#comment146677>

    no need to install ssl package for ubuntu?


- Vinod Kone


On July 21, 2015, 8:30 p.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36646/
> -----------------------------------------------------------
> 
> (Updated July 21, 2015, 8:30 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Bugs: MESOS-2963
>     https://issues.apache.org/jira/browse/MESOS-2963
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Also added libevent dependency to jenkins build.
> 
> In jenkins we can now provide 3 options for the `CONFIGURATION` environment variable that are: ` ` for the default build, `--enable-libevent` for libevent, and `--enable-libevent --enable-ssl` for SSL.
> 
> 
> Diffs
> -----
> 
>   support/jenkins_build.sh 7276fe28b558d96f90fc950b3ffad78573732eef 
> 
> Diff: https://reviews.apache.org/r/36646/diff/
> 
> 
> Testing
> -------
> 
> `OS="CENTOS" COMPILER="GCC" CONFIGURATION="--enable-libevent --enable-ssl" ./support/jenkins_build.sh`
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>