You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2020/11/19 01:37:48 UTC

[GitHub] [samza] MabelYC commented on a change in pull request #1437: SAMZA-2598:Kafka clients are not created and closed properly

MabelYC commented on a change in pull request #1437:
URL: https://github.com/apache/samza/pull/1437#discussion_r526535064



##########
File path: samza-core/src/main/java/org/apache/samza/coordinator/metadatastore/CoordinatorStreamStore.java
##########
@@ -111,6 +111,12 @@ public void init() {
       systemConsumer.start();
       systemProducer.register(SOURCE);
       systemProducer.start();
+      Runtime.getRuntime().addShutdownHook(new Thread(() -> {
+        LOG.info("CoordinatorStreamStore Shut Down Hook thread is closing kafka clients");
+        this.systemProducer.stop();

Review comment:
       changed




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org