You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "hughsimpson (via GitHub)" <gi...@apache.org> on 2024/10/10 12:13:19 UTC
[PR] annotate some instrumented methods with @noinline [pekko-http]
hughsimpson opened a new pull request, #616:
URL: https://github.com/apache/pekko-http/pull/616
In a similar vein to https://github.com/apache/pekko/pull/1489, this fixes Kamon instrumentation of http2 flows in pekko-http 1.1.+
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] annotate some instrumented methods with @noinline [pekko-http]
Posted by "hughsimpson (via GitHub)" <gi...@apache.org>.
hughsimpson commented on PR #616:
URL: https://github.com/apache/pekko-http/pull/616#issuecomment-2406911690
@pjfanning this fixed the downstream tests, thanks again. Will cut a new Kamon release today, and eagerly await the next pekko-http so that we can all be happy and compatible 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] annotate some instrumented methods with @noinline [pekko-http]
Posted by "hughsimpson (via GitHub)" <gi...@apache.org>.
hughsimpson commented on PR #616:
URL: https://github.com/apache/pekko-http/pull/616#issuecomment-2405081670
@pjfanning pushed [here](https://github.com/kamon-io/Kamon/pull/1362). Test failures visible [here](https://github.com/kamon-io/Kamon/actions/runs/11274625363/job/31354185367?pr=1362)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] annotate some instrumented methods with @noinline [pekko-http]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #616:
URL: https://github.com/apache/pekko-http/pull/616#issuecomment-2405445264
Merged - a set of snapshot jars should be published to Apache Nexus tonight
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] annotate some instrumented methods with @noinline [pekko-http]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #616:
URL: https://github.com/apache/pekko-http/pull/616#issuecomment-2404990962
Seems ok. @hughsimpson Can you link some of the broken Kamon tests or some general background as to what is fixed by this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] annotate some instrumented methods with @noinline [pekko-http]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #616:
URL: https://github.com/apache/pekko-http/pull/616
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] annotate some instrumented methods with @noinline [pekko-http]
Posted by "hughsimpson (via GitHub)" <gi...@apache.org>.
hughsimpson commented on PR #616:
URL: https://github.com/apache/pekko-http/pull/616#issuecomment-2405542297
🙏 Thanks very much!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org