[GitHub] [incubator-pegasus] levy5307 commented on a change in pull request #817: feat: add a config of periodic_compaction_seconds in rocksdb

[GitBox <gi...@apache.org>]

levy5307 commented on a change in pull request #817:
URL: https://github.com/apache/incubator-pegasus/pull/817#discussion_r717423501



##########
File path: src/server/pegasus_server_impl_init.cpp
##########
@@ -527,6 +527,12 @@ pegasus_server_impl::pegasus_server_impl(dsn::replication::replica *r)
     _key_ttl_compaction_filter_factory = std::make_shared<KeyWithTTLCompactionFilterFactory>();
     _data_cf_opts.compaction_filter_factory = _key_ttl_compaction_filter_factory;
 
+    _data_cf_opts.periodic_compaction_seconds =
+        dsn_config_get_value_uint64("pegasus.server",
+                                    "rocksdb_periodic_compaction_seconds",
+                                    30 * 24 * 60 * 60,

Review comment:
       I think the default value should be UINT64_MAX-1, which is default value in rocksdb




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org