You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by "lixiaobao (JIRA)" <ji...@apache.org> on 2019/07/08 11:38:00 UTC

[jira] [Created] (FLINK-13147) Duplicated code in 'if' conditional statement

lixiaobao created FLINK-13147:
---------------------------------

             Summary:  Duplicated code in 'if' conditional statement
                 Key: FLINK-13147
                 URL: https://issues.apache.org/jira/browse/FLINK-13147
             Project: Flink
          Issue Type: Bug
          Components: Connectors / Hive
    Affects Versions: 1.8.1, 1.8.0, 1.7.2, 1.6.4, 1.6.3
            Reporter: lixiaobao
             Fix For: 1.7.3, 1.9.0


{code:java}
} else if (type.equals(LogicalTypeRoot.VARBINARY)
 || type.equals(LogicalTypeRoot.BINARY)
 || type.equals(LogicalTypeRoot.BINARY)) {
 if (colStat instanceof CatalogColumnStatisticsDataBinary) {
 CatalogColumnStatisticsDataBinary binaryColumnStatsData = (CatalogColumnStatisticsDataBinary) colStat;
 BinaryColumnStatsData binaryColumnStats = new BinaryColumnStatsData(binaryColumnStatsData.getMaxLength(), binaryColumnStatsData.getAvgLength(), binaryColumnStatsData.getNullCount());
 return ColumnStatisticsData.binaryStats(binaryColumnStats);
 }{code}
The class HiveStatsUtil have  duplicated code in 'if' conditional statement.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)