You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by ham1 <gi...@git.apache.org> on 2017/12/23 14:17:24 UTC
[GitHub] jmeter pull request #366: Set max line length to 160 (eventual target 120).
GitHub user ham1 opened a pull request:
https://github.com/apache/jmeter/pull/366
Set max line length to 160 (eventual target 120).
## Description
Added new checkstyle rule for max line length of 160; with the view to, eventually, make it around 120. I will create another PR with the rest of the changes from #358 once this is merged as it should make merging slightly easier.
Hopefully reducing the scope and splitting this into commits that each change a separate thing will help merging - let me know if it's too much and I could split further if required.
## Motivation and Context
This PR will prevent any extra long lines and extra long anonymous inner classes being accidentally added.
## Checklist:
- [x] My code follows the [code style][style-guide] of this project.
- [x] I have updated the documentation accordingly.
[style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ham1/jmeter max_line_length
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jmeter/pull/366.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #366
----
commit c02a4e7529cea8ea043fd918073f0b60774d1729
Author: Graham Russell <gr...@...>
Date: 2017-12-23T13:59:56Z
Set max line length to 160 (eventual target 120).
commit 00ab78f50374027f7506a8143fdbbfc07dbdc21c
Author: Graham Russell <gr...@...>
Date: 2017-12-23T14:02:05Z
removed blank lines and superfluous comments
commit 6dd2f65d48957adc81373919fcba77c0c6355c5b
Author: Graham Russell <gr...@...>
Date: 2017-12-23T14:02:24Z
formatting and spelling
----
---
[GitHub] jmeter issue #366: Set max line length to 160 (eventual target 120).
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/jmeter/pull/366
# [Codecov](https://codecov.io/gh/apache/jmeter/pull/366?src=pr&el=h1) Report
> Merging [#366](https://codecov.io/gh/apache/jmeter/pull/366?src=pr&el=desc) into [trunk](https://codecov.io/gh/apache/jmeter/commit/998b3302a10ad8f298c12e67e08369f5a205018d?src=pr&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `47.81%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/jmeter/pull/366/graphs/tree.svg?width=650&height=150&src=pr&token=6Q7CI1wFSh)](https://codecov.io/gh/apache/jmeter/pull/366?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## trunk #366 +/- ##
============================================
+ Coverage 58.35% 58.36% +0.01%
- Complexity 10288 10289 +1
============================================
Files 1164 1164
Lines 74127 74225 +98
Branches 7298 7305 +7
============================================
+ Hits 43254 43323 +69
- Misses 28359 28389 +30
+ Partials 2514 2513 -1
```
| [Impacted Files](https://codecov.io/gh/apache/jmeter/pull/366?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/jmeter/control/gui/ModuleControllerGui.java](https://codecov.io/gh/apache/jmeter/pull/366/diff?src=pr&el=tree#diff-c3JjL2NvbXBvbmVudHMvb3JnL2FwYWNoZS9qbWV0ZXIvY29udHJvbC9ndWkvTW9kdWxlQ29udHJvbGxlckd1aS5qYXZh) | `30.76% <ø> (ø)` | `8 <0> (ø)` | :arrow_down: |
| [...jmeter/protocol/http/util/accesslog/LogFilter.java](https://codecov.io/gh/apache/jmeter/pull/366/diff?src=pr&el=tree#diff-c3JjL3Byb3RvY29sL2h0dHAvb3JnL2FwYWNoZS9qbWV0ZXIvcHJvdG9jb2wvaHR0cC91dGlsL2FjY2Vzc2xvZy9Mb2dGaWx0ZXIuamF2YQ==) | `81.3% <ø> (ø)` | `35 <0> (ø)` | :arrow_down: |
| [...rg/apache/jmeter/util/keystore/JmeterKeyStore.java](https://codecov.io/gh/apache/jmeter/pull/366/diff?src=pr&el=tree#diff-c3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvdXRpbC9rZXlzdG9yZS9KbWV0ZXJLZXlTdG9yZS5qYXZh) | `19.54% <ø> (ø)` | `4 <0> (ø)` | :arrow_down: |
| [...ts/org/apache/jmeter/visualizers/RenderAsJSON.java](https://codecov.io/gh/apache/jmeter/pull/366/diff?src=pr&el=tree#diff-c3JjL2NvbXBvbmVudHMvb3JnL2FwYWNoZS9qbWV0ZXIvdmlzdWFsaXplcnMvUmVuZGVyQXNKU09OLmphdmE=) | `60% <ø> (ø)` | `12 <0> (ø)` | :arrow_down: |
| [...g/apache/jmeter/samplers/AbstractSampleSender.java](https://codecov.io/gh/apache/jmeter/pull/366/diff?src=pr&el=tree#diff-c3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvc2FtcGxlcnMvQWJzdHJhY3RTYW1wbGVTZW5kZXIuamF2YQ==) | `80% <ø> (ø)` | `2 <0> (ø)` | :arrow_down: |
| [...protocol/http/sampler/LazySchemeSocketFactory.java](https://codecov.io/gh/apache/jmeter/pull/366/diff?src=pr&el=tree#diff-c3JjL3Byb3RvY29sL2h0dHAvb3JnL2FwYWNoZS9qbWV0ZXIvcHJvdG9jb2wvaHR0cC9zYW1wbGVyL0xhenlTY2hlbWVTb2NrZXRGYWN0b3J5LmphdmE=) | `66.66% <ø> (ø)` | `5 <0> (ø)` | :arrow_down: |
| [.../org/apache/jmeter/report/core/SampleMetadata.java](https://codecov.io/gh/apache/jmeter/pull/366/diff?src=pr&el=tree#diff-c3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvcmVwb3J0L2NvcmUvU2FtcGxlTWV0YWRhdGEuamF2YQ==) | `26.08% <ø> (ø)` | `8 <0> (ø)` | :arrow_down: |
| [.../backend/graphite/PickleGraphiteMetricsSender.java](https://codecov.io/gh/apache/jmeter/pull/366/diff?src=pr&el=tree#diff-c3JjL2NvbXBvbmVudHMvb3JnL2FwYWNoZS9qbWV0ZXIvdmlzdWFsaXplcnMvYmFja2VuZC9ncmFwaGl0ZS9QaWNrbGVHcmFwaGl0ZU1ldHJpY3NTZW5kZXIuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...er/protocol/http/proxy/AbstractSamplerCreator.java](https://codecov.io/gh/apache/jmeter/pull/366/diff?src=pr&el=tree#diff-c3JjL3Byb3RvY29sL2h0dHAvb3JnL2FwYWNoZS9qbWV0ZXIvcHJvdG9jb2wvaHR0cC9wcm94eS9BYnN0cmFjdFNhbXBsZXJDcmVhdG9yLmphdmE=) | `59.37% <ø> (ø)` | `6 <0> (ø)` | :arrow_down: |
| [...er/protocol/http/modifier/RegExUserParameters.java](https://codecov.io/gh/apache/jmeter/pull/366/diff?src=pr&el=tree#diff-c3JjL3Byb3RvY29sL2h0dHAvb3JnL2FwYWNoZS9qbWV0ZXIvcHJvdG9jb2wvaHR0cC9tb2RpZmllci9SZWdFeFVzZXJQYXJhbWV0ZXJzLmphdmE=) | `27.08% <0%> (-0.58%)` | `9 <0> (ø)` | |
| ... and [32 more](https://codecov.io/gh/apache/jmeter/pull/366/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/jmeter/pull/366?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/jmeter/pull/366?src=pr&el=footer). Last update [998b330...408b0ad](https://codecov.io/gh/apache/jmeter/pull/366?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---
[GitHub] jmeter pull request #366: Set max line length to 160 (eventual target 120).
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/jmeter/pull/366
---