You are viewing a plain text version of this content. The canonical link for it is here.
Posted to java-dev@axis.apache.org by sc...@us.ibm.com on 2002/08/12 23:34:30 UTC

RE: cvs commit: xml-axis/java/test/wsdl/sequence SequenceService. java deploy.wsdd readme.txt SequenceTest.wsdl SequenceTestServiceTestCase .java buildComponent.xml SequenceInfo.java SequenceTestSoapBindingImpl.ja va

I am fine with the change.

The WSDL<->Java, Java<->WSDL stuff is probably superfluous with the new
changes to Axis.

I won't apologize for adding tests. This was an important test and will
continue to be an important test.
I also agree with adding readme files.  Moving to a new test bench will
make it easier to package and describe individual tests.

Rich Scheuerle
IBM WebSphere & Axis Web Services Development
512-838-5115  (IBM TL 678-5115)


                                                                                                                                 
                      Tom Jordahl                                                                                                
                      <tomj@macromedia.        To:       "'axis-dev@xml.apache.org'" <ax...@xml.apache.org>                   
                      com>                     cc:                                                                               
                                               Subject:  RE: cvs commit: xml-axis/java/test/wsdl/sequence SequenceService.       
                      07/30/2002 09:07          java deploy.wsdd readme.txt SequenceTest.wsdl SequenceTestServiceTestCase  .java 
                      AM                        buildComponent.xml SequenceInfo.java SequenceTestSoapBindingImpl.ja  va          
                      Please respond to                                                                                          
                      axis-dev                                                                                                   
                                                                                                                                 
                                                                                                                                 




Glen,

You didn't make a message for the SAXException in BodyBuilder.java.
You have a literal string message.

SequenceService.java has incomplete class level comments:
  /**
   * Sequence test service.  This is a custom built message-style service
   * which confirms that
   *
   * @author Glen Daniels (gdaniels@apache.org)
   */

Removing the WSDL2Java -> Java2WSDL -> WSDL2Java round trip is definitely
removing part of the test.  Do we have any other tests that compare the
original and generated WSDL?  We probably should...

+1 on having comments or a readme.txt file for each test.

--
Tom Jordahl
Macromedia


-----Original Message-----
From: gdaniels@apache.org [mailto:gdaniels@apache.org]
Sent: Tuesday, July 30, 2002 2:16 AM
To: xml-axis-cvs@apache.org
Subject: cvs commit: xml-axis/java/test/wsdl/sequence
SequenceService.java deploy.wsdd readme.txt SequenceTest.wsdl
SequenceTestServiceTestCase.java buildComponent.xml SequenceInfo.java
SequenceTestSoapBindingImpl.java


gdaniels    2002/07/29 23:16:04

  Modified:    java/src/org/apache/axis/encoding/ser BeanDeserializer.java
                        BeanPropertyTarget.java
               java/src/org/apache/axis/message BodyBuilder.java
               java/src/org/apache/axis/utils BeanPropertyDescriptor.java
                        BeanUtils.java
               java/test/wsdl Wsdl2javaTestSuite.xml
               java/test/wsdl/arrays PersonalInfoBookServiceTestCase.java
               java/test/wsdl/sequence SequenceTest.wsdl
                        SequenceTestServiceTestCase.java buildComponent.xml
  Added:       java/src/org/apache/axis/utils FieldPropertyDescriptor.java
               java/test/wsdl/sequence SequenceService.java deploy.wsdd
                        readme.txt
  Removed:     java/test/wsdl/sequence SequenceInfo.java
                        SequenceTestSoapBindingImpl.java
  Log:
  Several changes which came up while investigating a problem
  serializing <sequence>s in the correct order.