You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@wicket.apache.org by vineet semwal <vi...@gmail.com> on 2011/06/23 22:58:18 UTC

regarding wicketstuff push

hellos !

i was just looking at wicketstuff push and i saw a lot of changes in
api and other improvements are done ,thanks for all that ! :)
as very new to the new push, could not understand the below channel
creation call..

 public <EventType> IPushChannel<EventType> createChannel(final
EventType event,	final String label)

why does a new channel creation needs event ?

i have also looked at the code i noticed "event" is just not used in
the channel creation method in AbstractPushService :|

i think method declaration can be improved or may be i am missing something ??



-- 
thank you,

regards,
Vineet Semwal

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org


Re: regarding wicketstuff push

Posted by vineet semwal <vi...@gmail.com>.
Hey seb ,

thanks for the quick fix !

On Fri, Jun 24, 2011 at 5:01 AM, Sebastian <no...@gmx.net> wrote:
> hi vineet,
>
> you are right. this is probably a left over from the refactoring we did. I
> just fixed it on github.
>
> regards,
>
> seb
>
> On 23.06.2011 22:58, vineet semwal wrote:
>>
>> hellos !
>>
>> i was just looking at wicketstuff push and i saw a lot of changes in
>> api and other improvements are done ,thanks for all that ! :)
>> as very new to the new push, could not understand the below channel
>> creation call..
>>
>>  public<EventType>  IPushChannel<EventType>  createChannel(final
>> EventType event,        final String label)
>>
>> why does a new channel creation needs event ?
>>
>> i have also looked at the code i noticed "event" is just not used in
>> the channel creation method in AbstractPushService :|
>>
>> i think method declaration can be improved or may be i am missing
>> something ??
>>
>>
>>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> For additional commands, e-mail: users-help@wicket.apache.org
>
>



-- 
thank you,

regards,
Vineet Semwal

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org


Re: regarding wicketstuff push

Posted by Sebastian <no...@gmx.net>.
hi vineet,

you are right. this is probably a left over from the refactoring we did. 
I just fixed it on github.

regards,

seb

On 23.06.2011 22:58, vineet semwal wrote:
> hellos !
>
> i was just looking at wicketstuff push and i saw a lot of changes in
> api and other improvements are done ,thanks for all that ! :)
> as very new to the new push, could not understand the below channel
> creation call..
>
>   public<EventType>  IPushChannel<EventType>  createChannel(final
> EventType event,	final String label)
>
> why does a new channel creation needs event ?
>
> i have also looked at the code i noticed "event" is just not used in
> the channel creation method in AbstractPushService :|
>
> i think method declaration can be improved or may be i am missing something ??
>
>
>



---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org