You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@synapse.apache.org by "Dave Brosius (JIRA)" <ji...@apache.org> on 2009/02/15 02:39:59 UTC

[jira] Created: (SYNAPSE-506) [PATCH] messageId isn't randomized

[PATCH] messageId isn't randomized
----------------------------------

                 Key: SYNAPSE-506
                 URL: https://issues.apache.org/jira/browse/SYNAPSE-506
             Project: Synapse
          Issue Type: Bug
          Components: Transports
    Affects Versions: 1.1.1
            Reporter: Dave Brosius
            Priority: Minor
             Fix For: 1.1.1
         Attachments: create_unique_message_ids.diff

Code attempts to add a random value to the message id, but it just appends 0 always instead, due to bad parenthesizing

             // compute the unique message ID
             String messageId = filePath + "_" + fileName +
-                "_" + System.currentTimeMillis() + "_" + (int) Math.random() * 1000;
+                "_" + System.currentTimeMillis() + "_" + (int) (Math.random() * 1000);


patch fixes this

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org


[jira] Updated: (SYNAPSE-506) [PATCH] messageId isn't randomized

Posted by "Dave Brosius (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SYNAPSE-506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dave Brosius updated SYNAPSE-506:
---------------------------------

    Attachment: create_unique_message_ids.diff

> [PATCH] messageId isn't randomized
> ----------------------------------
>
>                 Key: SYNAPSE-506
>                 URL: https://issues.apache.org/jira/browse/SYNAPSE-506
>             Project: Synapse
>          Issue Type: Bug
>          Components: Transports
>    Affects Versions: 1.1.1
>            Reporter: Dave Brosius
>            Priority: Minor
>             Fix For: 1.1.1
>
>         Attachments: create_unique_message_ids.diff
>
>
> Code attempts to add a random value to the message id, but it just appends 0 always instead, due to bad parenthesizing
>              // compute the unique message ID
>              String messageId = filePath + "_" + fileName +
> -                "_" + System.currentTimeMillis() + "_" + (int) Math.random() * 1000;
> +                "_" + System.currentTimeMillis() + "_" + (int) (Math.random() * 1000);
> patch fixes this

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org


[jira] Resolved: (SYNAPSE-506) [PATCH] messageId isn't randomized

Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SYNAPSE-506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andreas Veithen resolved SYNAPSE-506.
-------------------------------------

       Resolution: Fixed
    Fix Version/s:     (was: 1.1.1)
                   1.3

Actually the computed messageId is never used, so I removed this piece of code. Thanks for you contribution!

> [PATCH] messageId isn't randomized
> ----------------------------------
>
>                 Key: SYNAPSE-506
>                 URL: https://issues.apache.org/jira/browse/SYNAPSE-506
>             Project: Synapse
>          Issue Type: Bug
>          Components: Transports
>    Affects Versions: 1.1.1
>            Reporter: Dave Brosius
>            Assignee: Andreas Veithen
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: create_unique_message_ids.diff
>
>
> Code attempts to add a random value to the message id, but it just appends 0 always instead, due to bad parenthesizing
>              // compute the unique message ID
>              String messageId = filePath + "_" + fileName +
> -                "_" + System.currentTimeMillis() + "_" + (int) Math.random() * 1000;
> +                "_" + System.currentTimeMillis() + "_" + (int) (Math.random() * 1000);
> patch fixes this

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org


[jira] Assigned: (SYNAPSE-506) [PATCH] messageId isn't randomized

Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SYNAPSE-506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andreas Veithen reassigned SYNAPSE-506:
---------------------------------------

    Assignee: Andreas Veithen

> [PATCH] messageId isn't randomized
> ----------------------------------
>
>                 Key: SYNAPSE-506
>                 URL: https://issues.apache.org/jira/browse/SYNAPSE-506
>             Project: Synapse
>          Issue Type: Bug
>          Components: Transports
>    Affects Versions: 1.1.1
>            Reporter: Dave Brosius
>            Assignee: Andreas Veithen
>            Priority: Minor
>             Fix For: 1.1.1
>
>         Attachments: create_unique_message_ids.diff
>
>
> Code attempts to add a random value to the message id, but it just appends 0 always instead, due to bad parenthesizing
>              // compute the unique message ID
>              String messageId = filePath + "_" + fileName +
> -                "_" + System.currentTimeMillis() + "_" + (int) Math.random() * 1000;
> +                "_" + System.currentTimeMillis() + "_" + (int) (Math.random() * 1000);
> patch fixes this

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org