[GitHub] [spark] Daniel-Davies commented on a change in pull request #35032: [SPARK-37738][PYTHON] Fix API skew in PySpark date functions

[GitBox <gi...@apache.org>]

Daniel-Davies commented on a change in pull request #35032:
URL: https://github.com/apache/spark/pull/35032#discussion_r775857724



##########
File path: python/pyspark/sql/tests/test_functions.py
##########
@@ -286,6 +286,45 @@ def test_dayofweek(self):
         row = df.select(dayofweek(df.date)).first()
         self.assertEqual(row[0], 2)
 
+    def test_date_add_function(self):
+        from pyspark.sql.functions import date_add, col

Review comment:
       Thank you for the review @HyukjinKwon - have amended as per your comments.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org