You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dubbo.apache.org by al...@apache.org on 2021/06/02 02:53:27 UTC
[dubbo-go] branch 3.0 updated: Tst: Add unit tests for app metadata
reporter of zookeeper (#1229)
This is an automated email from the ASF dual-hosted git repository.
alexstocks pushed a commit to branch 3.0
in repository https://gitbox.apache.org/repos/asf/dubbo-go.git
The following commit(s) were added to refs/heads/3.0 by this push:
new d32458b Tst: Add unit tests for app metadata reporter of zookeeper (#1229)
d32458b is described below
commit d32458b08d54c757f0b382a0397306b483f2fdef
Author: XavierNiu <a...@nxw.name>
AuthorDate: Wed Jun 2 10:53:21 2021 +0800
Tst: Add unit tests for app metadata reporter of zookeeper (#1229)
* unit tests for app metadata reporter of zookeeper
* fix unused test case
---
metadata/report/zookeeper/report_test.go | 50 ++++++++++++++++++++++++++------
1 file changed, 41 insertions(+), 9 deletions(-)
diff --git a/metadata/report/zookeeper/report_test.go b/metadata/report/zookeeper/report_test.go
index 4f27da4..8d718db 100644
--- a/metadata/report/zookeeper/report_test.go
+++ b/metadata/report/zookeeper/report_test.go
@@ -70,7 +70,7 @@ func newServiceMetadataIdentifier(side string) *identifier.ServiceMetadataIdenti
}
}
-func newSubscribeMetadataIdentifier(side string) *identifier.SubscriberMetadataIdentifier {
+func newSubscribeMetadataIdentifier() *identifier.SubscriberMetadataIdentifier {
return &identifier.SubscriberMetadataIdentifier{
Revision: "1.0",
BaseApplicationMetadataIdentifier: identifier.BaseApplicationMetadataIdentifier{Application: "provider"},
@@ -120,7 +120,7 @@ func (suite *zookeeperMetadataReportTestSuite) testGetExportedURLs() {
}
func (suite *zookeeperMetadataReportTestSuite) testSaveSubscribedData(url *common.URL) {
- subscribeMi := newSubscribeMetadataIdentifier("provider")
+ subscribeMi := newSubscribeMetadataIdentifier()
urls := []string{url.String()}
bytes, _ := json.Marshal(urls)
err := suite.m.SaveSubscribedData(subscribeMi, string(bytes))
@@ -128,7 +128,7 @@ func (suite *zookeeperMetadataReportTestSuite) testSaveSubscribedData(url *commo
}
func (suite *zookeeperMetadataReportTestSuite) testGetSubscribedURLs() {
- subscribeMi := newSubscribeMetadataIdentifier("provider")
+ subscribeMi := newSubscribeMetadataIdentifier()
urls, err := suite.m.GetSubscribedURLs(subscribeMi)
assert.Equal(suite.t, 1, len(urls))
assert.NoError(suite.t, err)
@@ -141,7 +141,21 @@ func (suite *zookeeperMetadataReportTestSuite) testGetServiceDefinition() {
assert.NoError(suite.t, err)
}
-func test1(t *testing.T) {
+func (suite *zookeeperMetadataReportTestSuite) testPublishAppMetadata() {
+ subscribeMi := newSubscribeMetadataIdentifier()
+ info := common.NewMetadataInfWithApp(subscribeMi.Application)
+ err := suite.m.PublishAppMetadata(subscribeMi, info)
+ assert.NoError(suite.t, err)
+}
+
+func (suite *zookeeperMetadataReportTestSuite) testGetAppMetadata() {
+ subscribeMi := newSubscribeMetadataIdentifier()
+ info, err := suite.m.GetAppMetadata(subscribeMi)
+ assert.NoError(suite.t, err)
+ assert.Equal(suite.t, "provider", info.App)
+}
+
+func testInterfaceMetadata(t *testing.T) {
testCluster, err := zk.StartTestCluster(1, nil, nil, zk.WithRetryTimes(20))
assert.NoError(t, err)
defer func() {
@@ -149,23 +163,41 @@ func test1(t *testing.T) {
assert.Nil(t, err)
}()
- url := newProviderRegistryUrl("127.0.0.1", testCluster.Servers[0].Port)
+ providerRegistryUrl := newProviderRegistryUrl("127.0.0.1", testCluster.Servers[0].Port)
mf := extension.GetMetadataReportFactory("zookeeper")
- m := mf.CreateMetadataReport(url)
+ m := mf.CreateMetadataReport(providerRegistryUrl)
suite := newZookeeperMetadataReportTestSuite(t, m)
suite.testStoreProviderMetadata()
suite.testStoreConsumerMetadata()
- suite.testSaveServiceMetadata(url)
+ suite.testSaveServiceMetadata(providerRegistryUrl)
suite.testGetExportedURLs()
suite.testRemoveServiceMetadata()
- suite.testSaveSubscribedData(url)
+ suite.testSaveSubscribedData(providerRegistryUrl)
suite.testGetSubscribedURLs()
suite.testGetServiceDefinition()
}
+func testAppMetadata(t *testing.T) {
+ testCluster, err := zk.StartTestCluster(1, nil, nil, zk.WithRetryTimes(20))
+ assert.NoError(t, err)
+ defer func() {
+ err := testCluster.Stop()
+ assert.Nil(t, err)
+ }()
+
+ providerRegistryUrl := newProviderRegistryUrl("127.0.0.1", testCluster.Servers[0].Port)
+ mf := extension.GetMetadataReportFactory("zookeeper")
+ m := mf.CreateMetadataReport(providerRegistryUrl)
+
+ suite := newZookeeperMetadataReportTestSuite(t, m)
+ suite.testPublishAppMetadata()
+ suite.testGetAppMetadata()
+}
+
// TestZookeeperMetadataReport is dependent on zookeeper-*-fatjar.jar,
// please execute `make -f ../../../Makefile prepare` before running unittest.
func TestZookeeperMetadataReport(t *testing.T) {
- t.Run("test1", test1)
+ t.Run("testInterfaceMetadata", testInterfaceMetadata)
+ t.Run("testAppMetadata", testAppMetadata)
}