[GitHub] [hbase] wchevreuil commented on a change in pull request #856: HBASE-21776: Duplicate "Set storagePolicy" debug logging

[GitBox <gi...@apache.org>]

wchevreuil commented on a change in pull request #856: HBASE-21776: Duplicate "Set storagePolicy" debug logging
URL: https://github.com/apache/hbase/pull/856#discussion_r350695127
 
 

 ##########
 File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionFileSystem.java
 ##########
 @@ -189,8 +189,14 @@ Path createStoreDir(final String familyName) throws IOException {
    * @param familyName The name of column family.
    * @param policyName The name of the storage policy
    */
-  public void setStoragePolicy(String familyName, String policyName) {
-    FSUtils.setStoragePolicy(this.fs, getStoreDir(familyName), policyName);
+  public void setStoragePolicy(String familyName, String policyName) throws IOException {
+    if (this.fs instanceof HFileSystem) {
 
 Review comment:
   I don't think it's a good idea adding dependency here to a specific FS implementation class, with the solely aim to reduce verbosity on TRACE logging (as the logging on `CommonFSUtils` are all TRACE). I understand, though, that the extra messaging can cause confusion while troubleshooting, so maybe we could specify the FS instance passed to `setStoragePolicy`along with the messages?  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services