[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #8766: Re-enable pylint for superset/utils folder

[GitBox <gi...@apache.org>]

mistercrunch commented on a change in pull request #8766: Re-enable pylint for superset/utils folder
URL: https://github.com/apache/incubator-superset/pull/8766#discussion_r355058694
 
 

 ##########
 File path: superset/utils/import_datasource.py
 ##########
 @@ -30,7 +29,7 @@ def import_datasource(
      superset instances. Audit metadata isn't copies over.
     """
     make_transient(i_datasource)
-    logging.info("Started import of the datasource: {}".format(i_datasource.to_json()))
+    logging.info("Started import of the datasource: %s", i_datasource.to_json())
 
 Review comment:
   fstrings and `.format` are not recommended for logging statements because they make you pay the cost of formatting the string regardless of logging level. Not that it's expensive, but it's best practice to use the format above for that reason

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org