You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "lhotari (via GitHub)" <gi...@apache.org> on 2026/10/12 15:17:52 UTC
Re: [PR] [improve][broker] Add a random value upto 5% to avoid rollover multiple cursor ledgers [pulsar]
lhotari commented on code in PR #26542:
URL: https://github.com/apache/pulsar/pull/26542#discussion_r4249624702
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java:
##########
@@ -4533,7 +4533,12 @@ public ManagedLedgerConfig getConfig() {
public void setConfig(ManagedLedgerConfig config) {
this.config = config;
this.maximumRolloverTimeMs = getMaximumRolloverTimeMs(config);
- this.cursors.forEach(c -> c.setThrottleMarkDelete(config.getThrottleMarkDelete()));
+ this.cursors.forEach(c -> {
+ if (c instanceof ManagedCursorImpl cursor) {
+ cursor.updateRolloverThresholds(config);
+ }
+ c.setThrottleMarkDelete(config.getThrottleMarkDelete());
+ });
}
Review Comment:
Thanks, this is moot now. The latest version only caches the jitter and reads the live config in `shouldCloseLedger`, so no `configUpdated` handler is needed. Resolving.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org