You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metamodel.apache.org by jhorcicka <gi...@git.apache.org> on 2016/08/08 08:55:58 UTC
[GitHub] metamodel pull request #123: METAMODEL-1111 Empty string treatment in Oracle
GitHub user jhorcicka opened a pull request:
https://github.com/apache/metamodel/pull/123
METAMODEL-1111 Empty string treatment in Oracle
Fixes Oracle '' = null problem. In OracleQueryRewriter empty string operand is reaplaced by null.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jhorcicka/metamodel oracle-rewriter
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metamodel/pull/123.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #123
----
commit 87da8deae80b134ffd3d8795b8f720d1470cb3ae
Author: jhorcicka <ja...@humaninference.com>
Date: 2016-08-05T14:55:34Z
OracleQueryRewriter: '' operand is replaced by null.
commit 11ccf6de9d51fdbd976a1a6662166f92377d83a0
Author: jhorcicka <ja...@humaninference.com>
Date: 2016-08-08T08:13:54Z
Oracle-rewriter: OracleQueryRewriterTest was added.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel issue #123: METAMODEL-1111 Empty string treatment in Oracle
Posted by jhorcicka <gi...@git.apache.org>.
Github user jhorcicka commented on the issue:
https://github.com/apache/metamodel/pull/123
According to https://docs.oracle.com/cd/B28359_01/server.111/b28318/datatype.htm#i3253 I tried CHAR, NCHAR, CLOB, NCLOB, VARCHAR2 and NVARCHAR2. In these cases when an empty string was assigned to the column, null was stored instead.
From what I read I think currently there is a general rule '' = null. It might change in the future when Oracle tries to standardize VARCHAR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request #123: METAMODEL-1111 Empty string treatment in Oracle
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/metamodel/pull/123
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel issue #123: METAMODEL-1111 Empty string treatment in Oracle
Posted by kaspersorensen <gi...@git.apache.org>.
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/123
OK, let's merge this then.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel issue #123: METAMODEL-1111 Empty string treatment in Oracle
Posted by kaspersorensen <gi...@git.apache.org>.
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/123
I wonder if this rule applies to all String-based data types in Oracle. Do we have any documentation to back it up? I could find references of this anomaly for `VARCHAR` and `VARCHAR2`, so maybe we need also to add a check on the data type to ensure that we don't rewrite it wrongly for other data types.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---