You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-dev@xmlgraphics.apache.org by Vincent Hennebert <vh...@gmail.com> on 2009/07/07 17:55:13 UTC
Re: svn commit: r791153 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr:
AbstractBreaker.java PageBreaker.java
Hi Andreas,
Again, most of the clean up looks good, only...
> Author: adelmelle
> Date: Sat Jul 4 17:00:05 2009
> New Revision: 791153
>
> URL: http://svn.apache.org/viewvc?rev=791153&view=rev
> Log:
> Further cleanup/readability improvements
>
> Modified:
> xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/AbstractBreaker.java
> URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/AbstractBreaker.java?rev=791153&r1=791152&r2=791153&view=diff
> ==============================================================================
> --- xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/AbstractBreaker.java (original)
> +++ xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/AbstractBreaker.java Sat Jul 4 17:00:05 2009
> @@ -399,7 +429,13 @@
> ListElement lastBreakElement = effectiveList.getElement(endElementIndex);
> if (lastBreakElement.isPenalty()) {
> KnuthPenalty pen = (KnuthPenalty)lastBreakElement;
> - lastBreakClass = pen.getBreakClass();
> + // TODO Handle keep.within-column differently so that break class is
> + // automatically set to the right value
> + if (pen.getP() >= KnuthPenalty.INFINITE - 1) {
> + lastBreakClass = Constants.EN_COLUMN;
> + } else {
> + lastBreakClass = pen.getBreakClass();
> + }
... Another leak from the keep-within-column patch?
Thanks,
Vincent
Re: svn commit: r791153 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr:
AbstractBreaker.java PageBreaker.java
Posted by Vincent Hennebert <vh...@gmail.com>.
Andreas Delmelle wrote:
> On 07 Jul 2009, at 17:55, Vincent Hennebert wrote:
>
> Hi Vincent
>
>>> .. Another leak from the keep-within-column patch?
>
> Indeed, but this one I caught soon after committing, so is already undone.
Of course. Stupid me :-|
Thanks, and sorry about the noise.
Vincent
Re: svn commit: r791153 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr: AbstractBreaker.java PageBreaker.java
Posted by Andreas Delmelle <an...@telenet.be>.
On 07 Jul 2009, at 17:55, Vincent Hennebert wrote:
Hi Vincent
>> .. Another leak from the keep-within-column patch?
Indeed, but this one I caught soon after committing, so is already
undone.
Regards
Andreas
Regards,
Andreas Delmelle
mailto:andreas.delmelle.AT.telenet.be
jabber: mandreas@jabber.org
skype: adlm0608
---