You are viewing a plain text version of this content. The canonical link for it is here.

Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2022/10/22 00:26:45 UTC

[GitHub] [hadoop] slfan1989 commented on pull request #5055: YARN-11357. Fix FederationClientInterceptor#submitApplication Can't Update SubClusterId

slfan1989 commented on PR #5055:
URL: https://github.com/apache/hadoop/pull/5055#issuecomment-1287552650

   @goiri Can you help to review the code? Thank you very much! 
   
   I am completing YARN-11342 (#5005), and there is a problem with the writing of one judgment condition, which will cause the subClusterId to be updated when retrying. 
   
   The modified content is as follows:
   1.Fix FederationClientInterceptor#submitApplication exists condition
   2.`actualRetryNums` does not need to add 1, because the Retry Count of `FederationActionRetry` starts from 0, we only need to provide the real number of retry. 
   The specific reasons have been described in the comments above.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org