You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by cr...@apache.org on 2003/08/16 20:18:26 UTC

cvs commit: jakarta-commons/digester/src/java/org/apache/commons/digester/xmlrules DigesterRuleParser.java FromXmlRuleSet.java

craigmcc    2003/08/16 11:18:26

  Modified:    digester/src/java/org/apache/commons/digester
                        FactoryCreateRule.java SetPropertiesRule.java
                        SetPropertyRule.java
               digester/src/java/org/apache/commons/digester/rss
                        Channel.java
               digester/src/java/org/apache/commons/digester/xmlrules
                        DigesterRuleParser.java FromXmlRuleSet.java
  Log:
  Cosmetic changes only, no functionality changes:
  * Cleaned up Javadoc generation warnings under JDK 1.4.2.
  * A few miscellaneous typos and >80 column comments
  
  Revision  Changes    Path
  1.13      +11 -9     jakarta-commons/digester/src/java/org/apache/commons/digester/FactoryCreateRule.java
  
  Index: FactoryCreateRule.java
  ===================================================================
  RCS file: /home/cvs/jakarta-commons/digester/src/java/org/apache/commons/digester/FactoryCreateRule.java,v
  retrieving revision 1.12
  retrieving revision 1.13
  diff -u -r1.12 -r1.13
  --- FactoryCreateRule.java	16 Apr 2003 11:23:50 -0000	1.12
  +++ FactoryCreateRule.java	16 Aug 2003 18:18:26 -0000	1.13
  @@ -275,7 +275,8 @@
        * then be used to create an object and push it on the stack.
        *
        * @param className Java class name of the object creation factory class
  -     * @param ignoreCreateException if true, exceptions thrown by the object creation factory
  +     * @param ignoreCreateExceptions if true, exceptions thrown by the object
  +     *  creation factory
        * will be ignored.
        */
       public FactoryCreateRule(String className, boolean ignoreCreateExceptions) {
  @@ -291,7 +292,8 @@
        * then be used to create an object and push it on the stack.
        *
        * @param clazz Java class name of the object creation factory class
  -     * @param ignoreCreateException if true, exceptions thrown by the object creation factory
  +     * @param ignoreCreateExceptions if true, exceptions thrown by the
  +     *  object creation factory
        * will be ignored.
        */
       public FactoryCreateRule(Class clazz, boolean ignoreCreateExceptions) {
  @@ -310,8 +312,8 @@
        * @param className Default Java class name of the factory class
        * @param attributeName Attribute name which, if present, contains an
        *  override of the class name of the object creation factory to create.
  -     * @param ignoreCreateException if true, exceptions thrown by the object creation factory
  -     * will be ignored.
  +     * @param ignoreCreateExceptions if true, exceptions thrown by the object
  +     *  creation factory will be ignored.
        */
       public FactoryCreateRule(
                                   String className, 
  @@ -334,8 +336,8 @@
        * @param clazz Default Java class name of the factory class
        * @param attributeName Attribute name which, if present, contains an
        *  override of the class name of the object creation factory to create.
  -     * @param ignoreCreateException if true, exceptions thrown by the object creation factory
  -     * will be ignored.
  +     * @param ignoreCreateExceptions if true, exceptions thrown by the object
  +     *  creation factory will be ignored.
        */
       public FactoryCreateRule(
                                   Class clazz, 
  @@ -352,8 +354,8 @@
        * {@link ObjectCreationFactory}.
        *
        * @param creationFactory called on to create the object.
  -     * @param ignoreCreateException if true, exceptions thrown by the object creation factory
  -     * will be ignored.
  +     * @param ignoreCreateExceptions if true, exceptions thrown by the object
  +     *  creation factory will be ignored.
        */
       public FactoryCreateRule(
                               ObjectCreationFactory creationFactory, 
  
  
  
  1.13      +5 -6      jakarta-commons/digester/src/java/org/apache/commons/digester/SetPropertiesRule.java
  
  Index: SetPropertiesRule.java
  ===================================================================
  RCS file: /home/cvs/jakarta-commons/digester/src/java/org/apache/commons/digester/SetPropertiesRule.java,v
  retrieving revision 1.12
  retrieving revision 1.13
  diff -u -r1.12 -r1.13
  --- SetPropertiesRule.java	16 Aug 2003 18:02:56 -0000	1.12
  +++ SetPropertiesRule.java	16 Aug 2003 18:18:26 -0000	1.13
  @@ -165,7 +165,7 @@
        * </pre></code>
        *
        * @param attributeNames names of attributes to map
  -     * @param proeprtyNames names of properties mapped to
  +     * @param propertyNames names of properties mapped to
        */
       public SetPropertiesRule(String[] attributeNames, String[] propertyNames) {
           // create local copies
  @@ -198,7 +198,6 @@
       /**
        * Process the beginning of this element.
        *
  -     * @param context The associated context
        * @param attributes The attribute list of this element
        */
       public void begin(Attributes attributes) throws Exception {
  
  
  
  1.12      +4 -5      jakarta-commons/digester/src/java/org/apache/commons/digester/SetPropertyRule.java
  
  Index: SetPropertyRule.java
  ===================================================================
  RCS file: /home/cvs/jakarta-commons/digester/src/java/org/apache/commons/digester/SetPropertyRule.java,v
  retrieving revision 1.11
  retrieving revision 1.12
  diff -u -r1.11 -r1.12
  --- SetPropertyRule.java	16 Apr 2003 11:23:50 -0000	1.11
  +++ SetPropertyRule.java	16 Aug 2003 18:18:26 -0000	1.12
  @@ -142,7 +142,6 @@
       /**
        * Process the beginning of this element.
        *
  -     * @param context The associated context
        * @param attributes The attribute list of this element
        *
        * @exception NoSuchMethodException if the bean does not
  
  
  
  1.7       +6 -6      jakarta-commons/digester/src/java/org/apache/commons/digester/rss/Channel.java
  
  Index: Channel.java
  ===================================================================
  RCS file: /home/cvs/jakarta-commons/digester/src/java/org/apache/commons/digester/rss/Channel.java,v
  retrieving revision 1.6
  retrieving revision 1.7
  diff -u -r1.6 -r1.7
  --- Channel.java	16 Apr 2003 11:23:51 -0000	1.6
  +++ Channel.java	16 Aug 2003 18:18:26 -0000	1.7
  @@ -332,9 +332,9 @@
   
   
       /**
  -     * Add an additional skip day name.
  +     * Add an additional skip hour name.
        *
  -     * @param skipDay The skip day to be added
  +     * @param skipHour The skip hour to be added
        */
       public void addSkipHour(String skipHour) {
           synchronized (skipHours) {
  
  
  
  1.16      +1 -4      jakarta-commons/digester/src/java/org/apache/commons/digester/xmlrules/DigesterRuleParser.java
  
  Index: DigesterRuleParser.java
  ===================================================================
  RCS file: /home/cvs/jakarta-commons/digester/src/java/org/apache/commons/digester/xmlrules/DigesterRuleParser.java,v
  retrieving revision 1.15
  retrieving revision 1.16
  diff -u -r1.15 -r1.16
  --- DigesterRuleParser.java	16 Apr 2003 11:23:51 -0000	1.15
  +++ DigesterRuleParser.java	16 Aug 2003 18:18:26 -0000	1.16
  @@ -291,7 +291,6 @@
           private String pattern = null;
           
           /**
  -         * @param digester the Digester used to parse the rules XML file
            * @param attrName The name of the attribute containing the pattern
            */
           public PatternRule(String attrName) {
  @@ -681,9 +680,7 @@
       protected class SetPropertiesAliasRule extends Rule {
           
           /**
  -         * <p>Base constructor.
  -         *
  -         * @param digester the Digester used to parse the rules XML file
  +         * <p>Base constructor.</p>
            */
           public SetPropertiesAliasRule() {
               super();
  
  
  
  1.7       +1 -1      jakarta-commons/digester/src/java/org/apache/commons/digester/xmlrules/FromXmlRuleSet.java
  
  Index: FromXmlRuleSet.java
  ===================================================================
  RCS file: /home/cvs/jakarta-commons/digester/src/java/org/apache/commons/digester/xmlrules/FromXmlRuleSet.java,v
  retrieving revision 1.6
  retrieving revision 1.7
  diff -u -r1.6 -r1.7
  --- FromXmlRuleSet.java	16 Apr 2003 11:23:51 -0000	1.6
  +++ FromXmlRuleSet.java	16 Aug 2003 18:18:26 -0000	1.7
  @@ -103,7 +103,7 @@
        * Constructs a FromXmlRuleSet using the default DigesterRuleParser and
        * a ruleDigester for loading the rules xml.
        * @param rulesXml the path to the XML document defining the Digester rules
  -     * @param ruleDigester the digester to read the rules xml.
  +     * @param rulesDigester the digester to read the rules xml.
        */
       public FromXmlRuleSet(URL rulesXml, Digester rulesDigester) {
           this(rulesXml, new DigesterRuleParser(), rulesDigester);