You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/10/22 03:35:01 UTC

[GitHub] [flink] meetjunsu opened a new pull request #17543: [FLINK-24613][doc]Documentation on orc supported data types is outdated

meetjunsu opened a new pull request #17543:
URL: https://github.com/apache/flink/pull/17543


   ## What is the purpose of the change
   
   Orc already supports complex types, and the documentation has not been updated in time.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (docs)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] JingsongLi merged pull request #17543: [FLINK-24613][doc]Documentation on orc supported data types is outdated

Posted by GitBox <gi...@apache.org>.
JingsongLi merged pull request #17543:
URL: https://github.com/apache/flink/pull/17543


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] meetjunsu commented on pull request #17543: [FLINK-24613][doc]Documentation on orc supported data types is outdated

Posted by GitBox <gi...@apache.org>.
meetjunsu commented on pull request #17543:
URL: https://github.com/apache/flink/pull/17543#issuecomment-949282656


   > Thanks @meetjunsu , can you modify zh too?
   
   updated in the latest commit.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #17543: [FLINK-24613][doc]Documentation on orc supported data types is outdated

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17543:
URL: https://github.com/apache/flink/pull/17543#issuecomment-949259104


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c22d562a53e78b81e7b2a35e4cd09f4a9c43087c",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25346",
       "triggerID" : "c22d562a53e78b81e7b2a35e4cd09f4a9c43087c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c1aea68fec99eb6e6e2ba9998ad9ccc9e36d2868",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25347",
       "triggerID" : "c1aea68fec99eb6e6e2ba9998ad9ccc9e36d2868",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c22d562a53e78b81e7b2a35e4cd09f4a9c43087c Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25346) 
   * c1aea68fec99eb6e6e2ba9998ad9ccc9e36d2868 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25347) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #17543: [FLINK-24613][doc]Documentation on orc supported data types is outdated

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17543:
URL: https://github.com/apache/flink/pull/17543#issuecomment-949259104


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c22d562a53e78b81e7b2a35e4cd09f4a9c43087c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "c22d562a53e78b81e7b2a35e4cd09f4a9c43087c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c22d562a53e78b81e7b2a35e4cd09f4a9c43087c UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #17543: [FLINK-24613][doc]Documentation on orc supported data types is outdated

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17543:
URL: https://github.com/apache/flink/pull/17543#issuecomment-949259104


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c22d562a53e78b81e7b2a35e4cd09f4a9c43087c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25346",
       "triggerID" : "c22d562a53e78b81e7b2a35e4cd09f4a9c43087c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c1aea68fec99eb6e6e2ba9998ad9ccc9e36d2868",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25347",
       "triggerID" : "c1aea68fec99eb6e6e2ba9998ad9ccc9e36d2868",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c1aea68fec99eb6e6e2ba9998ad9ccc9e36d2868 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25347) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] meetjunsu commented on a change in pull request #17543: [FLINK-24613][doc]Documentation on orc supported data types is outdated

Posted by GitBox <gi...@apache.org>.
meetjunsu commented on a change in pull request #17543:
URL: https://github.com/apache/flink/pull/17543#discussion_r734216122



##########
File path: docs/content/docs/connectors/table/formats/orc.md
##########
@@ -168,9 +168,20 @@ The following table lists the type mapping from Flink type to Orc type.
       <td>timestamp</td>
       <td>TIMESTAMP</td>
     </tr>
+    <tr>
+      <td>ARRAY</td>
+      <td>-</td>

Review comment:
       The physical type of the composite type is based on the element type, so nothing is written in this item




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #17543: [FLINK-24613][doc]Documentation on orc supported data types is outdated

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17543:
URL: https://github.com/apache/flink/pull/17543#issuecomment-949259915


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit c22d562a53e78b81e7b2a35e4cd09f4a9c43087c (Fri Oct 22 03:38:27 UTC 2021)
   
   **Warnings:**
    * Documentation files were touched, but no `docs/content.zh/` files: Update Chinese documentation or file Jira ticket.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #17543: [FLINK-24613][doc]Documentation on orc supported data types is outdated

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17543:
URL: https://github.com/apache/flink/pull/17543#issuecomment-949259104


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c22d562a53e78b81e7b2a35e4cd09f4a9c43087c",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25346",
       "triggerID" : "c22d562a53e78b81e7b2a35e4cd09f4a9c43087c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c1aea68fec99eb6e6e2ba9998ad9ccc9e36d2868",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "c1aea68fec99eb6e6e2ba9998ad9ccc9e36d2868",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c22d562a53e78b81e7b2a35e4cd09f4a9c43087c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25346) 
   * c1aea68fec99eb6e6e2ba9998ad9ccc9e36d2868 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] JingsongLi commented on pull request #17543: [FLINK-24613][doc]Documentation on orc supported data types is outdated

Posted by GitBox <gi...@apache.org>.
JingsongLi commented on pull request #17543:
URL: https://github.com/apache/flink/pull/17543#issuecomment-949271946


   Thanks @meetjunsu , can you modify zh too?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #17543: [FLINK-24613][doc]Documentation on orc supported data types is outdated

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17543:
URL: https://github.com/apache/flink/pull/17543#issuecomment-949259104


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c22d562a53e78b81e7b2a35e4cd09f4a9c43087c",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25346",
       "triggerID" : "c22d562a53e78b81e7b2a35e4cd09f4a9c43087c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c22d562a53e78b81e7b2a35e4cd09f4a9c43087c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25346) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #17543: [FLINK-24613][doc]Documentation on orc supported data types is outdated

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17543:
URL: https://github.com/apache/flink/pull/17543#issuecomment-949259104


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c22d562a53e78b81e7b2a35e4cd09f4a9c43087c",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25346",
       "triggerID" : "c22d562a53e78b81e7b2a35e4cd09f4a9c43087c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c1aea68fec99eb6e6e2ba9998ad9ccc9e36d2868",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25347",
       "triggerID" : "c1aea68fec99eb6e6e2ba9998ad9ccc9e36d2868",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c22d562a53e78b81e7b2a35e4cd09f4a9c43087c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25346) 
   * c1aea68fec99eb6e6e2ba9998ad9ccc9e36d2868 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25347) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org