[jira] [Commented] (MYFACES-3318) Documentation for insert ajax command does not match with spec xsd

["Werner Punz (JIRA)" <de...@myfaces.apache.org>]

    [ https://issues.apache.org/jira/browse/MYFACES-3318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13113201#comment-13113201 ] 

Werner Punz commented on MYFACES-3318:
--------------------------------------

I think the best would be simply to implement both on the javascript side, since both parsing paths are not mutually exclusive.
insert before or after attribute set use the path from the jsdocs, insert with a separate before or after use the path from the spec.
That way the impl can decide which one to use, for me it is not really that much of additional work. I will add this stuff next week, when I work on the jsf.js impl again in myfaces.


> Documentation for insert ajax command does not match with spec xsd
> ------------------------------------------------------------------
>
>                 Key: MYFACES-3318
>                 URL: https://issues.apache.org/jira/browse/MYFACES-3318
>             Project: MyFaces Core
>          Issue Type: Bug
>          Components: JSR-314
>            Reporter: Leonardo Uribe
>         Attachments: MYFACES-3318-1.patch
>
>
> The spec javascript documentation says this:
> If an <insert> element is found in the response with the attribute before:
> <insert id="insert id" before="before id">
>    <![CDATA[...]]>
> </insert>
>     Extract this <insert> element's CDATA contents from the response.
>     Find the DOM element whose identifier matches before id and insert the <insert> element's CDATA content before the DOM element in the document.
> If an <insert> element is found in the response with the attribute after:
> <insert id="insert id" after="after id">
>    <![CDATA[...]]>
> </insert>
>     Extract this <insert> element's CDATA contents from the response.
>     Find the DOM element whose identifier matches after id and insert the <insert> element's CDATA content after the DOM element in the document.
> But JSF 2.0 Appendix A about partial response xml says it should be:
> <insert>
> <before id="before id">
>    <![CDATA[...]]>
> </before>
> </insert>
> <insert>
> <after id="after id">
>    <![CDATA[...]]>
> </after>
> </insert>
> MyFaces implements the description on the javascript doc, but Mojarra follows the structure inside the spec. In this case the spec takes precedence over the javascript doc.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira