[GitHub] [superset] suddjian commented on a change in pull request #12524: fix(native-filters): Improve UI for long native filters names

[GitBox <gi...@apache.org>]

suddjian commented on a change in pull request #12524:
URL: https://github.com/apache/superset/pull/12524#discussion_r558536576



##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FilterConfigModal.tsx
##########
@@ -82,6 +82,7 @@ const FilterTabs = styled(LineEditableTabs)`
 const FilterTabTitle = styled.span`
   transition: color ${({ theme }) => theme.transitionTiming}s;
   width: 100%;
+  max-width: 200px;

Review comment:
       Can we make this based on a constant, or on grid units?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org