[GitHub] weichao666 commented on a change in pull request #741: [SCB-625] ProduceProcessor use SPI to support extends

[GitBox <gi...@apache.org>]

weichao666 commented on a change in pull request #741: [SCB-625] ProduceProcessor use SPI to support extends
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/741#discussion_r193618594
 
 

 ##########
 File path: common/common-rest/src/main/java/org/apache/servicecomb/common/rest/codec/produce/ProduceProcessorManager.java
 ##########
 @@ -17,24 +17,43 @@
 
 package org.apache.servicecomb.common.rest.codec.produce;
 
+import java.util.ServiceLoader;
+
 import javax.ws.rs.core.MediaType;
 
 import org.apache.servicecomb.foundation.common.RegisterManager;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 public final class ProduceProcessorManager extends RegisterManager<String, ProduceProcessor> {
+  private static final Logger LOGGER = LoggerFactory.getLogger(ProduceProcessorManager.class);
+
+  private static final ServiceLoader<ProduceProcessor> produceProcessor = ServiceLoader.load(ProduceProcessor.class);
 
 Review comment:
   done, there is still one question: what number should json and text/plain return when getOrder, i use 10 and 11 now

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services