[Bug 66061] New: DefaultSamplerCreator gives inaccurate log message saying "setting path ... " after already set the path

[bu...@apache.org]

https://bz.apache.org/bugzilla/show_bug.cgi?id=66061

            Bug ID: 66061
           Summary: DefaultSamplerCreator  gives inaccurate log message
                    saying "setting path ... " after already set the path
           Product: JMeter
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P2
         Component: HTTP
          Assignee: issues@jmeter.apache.org
          Reporter: dingzishuo@gmail.com
  Target Milestone: JMETER_5.5

Hello,

While viewing the https://issues.apache.org/jira/browse/MAPREDUCE-4262, I found
that the logging statements might give inaccurate messages. 

I also found that the in the line 420 of the file DefaultSamplerCreator.java,
the log messages says "setting path...". However, the path should already be
set in previous lines of code.

Would it be better if we change the verb "setting" to "have set" to indicate
the action is completed? Or can we move the logging statement to the begining
of the method? Since when there was an exception in previous lines, the logging
message would not be printed, which may be not good for debugging.


The detailed url is:
https://github.com/apache/jmeter/blob/659c1ff5eaea941eb7ad0638b58e904dcc06d961/src/protocol/http/src/main/java/org/apache/jmeter/protocol/http/proxy/DefaultSamplerCreator.java/#L420

-- 
You are receiving this mail because:
You are the assignee for the bug.