[jira] [Commented] (DRILL-6054) Issues in FindPartitionConditions

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-6054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16320179#comment-16320179 ] 

ASF GitHub Bot commented on DRILL-6054:
---------------------------------------

Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1078#discussion_r160664549
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/FindPartitionConditions.java ---
    @@ -228,13 +236,16 @@ private boolean isHolisticExpression(RexCall call) {
         return false;
       }
     
    +  protected boolean inputRefToPush(RexInputRef inputRef) {
    --- End diff --
    
    Can be made private. Should be placed under public methods.


> Issues in FindPartitionConditions
> ---------------------------------
>
>                 Key: DRILL-6054
>                 URL: https://issues.apache.org/jira/browse/DRILL-6054
>             Project: Apache Drill
>          Issue Type: Bug
>    Affects Versions: 1.12.0
>            Reporter: Chunhui Shi
>            Assignee: Chunhui Shi
>             Fix For: 1.13.0
>
>
> When the condition is these cases, partition is not done correctly: 
> b = 3 OR (dir0 = 1 and a = 2)
> not (dir0 = 1 AND b = 2)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)