[GitHub] [accumulo] ctubbsii commented on a change in pull request #2006: Ensure that the HostRegexTableLoadBalancer property changes are picked up

[GitBox <gi...@apache.org>]

ctubbsii commented on a change in pull request #2006:
URL: https://github.com/apache/accumulo/pull/2006#discussion_r608824695



##########
File path: server/base/src/main/java/org/apache/accumulo/server/master/balancer/HostRegexTableLoadBalancer.java
##########
@@ -252,6 +252,14 @@ protected void parseConfiguration(ServerConfiguration conf) {
     tableIdToTableName = ImmutableMap.copyOf(tableIdToTableNameBuilder);
     poolNameToRegexPattern = ImmutableMap.copyOf(poolNameToRegexPatternBuilder);
 
+    LOG.info("{}", this);

Review comment:
       Is this necessary, or was it left in during development?

##########
File path: server/base/src/main/java/org/apache/accumulo/server/master/balancer/HostRegexTableLoadBalancer.java
##########
@@ -220,7 +220,7 @@ protected String getPoolNameForTable(String tableName) {
    * @param conf
    *          server configuration
    */
-  protected void parseConfiguration(ServerConfiguration conf) {

Review comment:
       Probably not a good idea to rename the protected method. Although this isn't public API, we have attempted to keep balancer APIs somewhat stable to reduce disruption.

##########
File path: server/base/src/main/java/org/apache/accumulo/server/master/balancer/HostRegexTableLoadBalancer.java
##########
@@ -252,6 +252,14 @@ protected void parseConfiguration(ServerConfiguration conf) {
     tableIdToTableName = ImmutableMap.copyOf(tableIdToTableNameBuilder);
     poolNameToRegexPattern = ImmutableMap.copyOf(poolNameToRegexPatternBuilder);
 
+    LOG.info("{}", this);
+  }
+
+  public void parseSystemConfiguration(ServerConfiguration conf) {

Review comment:
       Should this new method be public?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org