You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Armand Grillet <ag...@mesosphere.io> on 2017/10/12 17:01:32 UTC
Review Request 62938: Added ZooKeeper leader resolution to CLI.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62938/
-----------------------------------------------------------
Review request for mesos and Kevin Klues.
Bugs: MESOS-8012
https://issues.apache.org/jira/browse/MESOS-8012
Repository: mesos
Description
-------
This change allows using the CLI with a Mesos running in high
availability mode. The `zookeeper` field was present before this
meeting, with an `addresses` array and a `path` field. This change
only adds the backend to actually make it usable.
Interacting with ZooKeeper requires a new dependency, kazoo, that has
been added to the list of requirements for the CLI.
Diffs
-----
src/python/cli_new/README.md a4b270d9b54cdd83bd62530fb44ddfaffb8a014b
src/python/cli_new/lib/cli/util.py dd109c09368e650b7d7dabd663c11bc2e3e5180a
src/python/cli_new/pip-requirements.txt 7aeac344c47ccd2588fded44d7314db7abd85653
Diff: https://reviews.apache.org/r/62938/diff/1/
Testing
-------
Tested with a Mesos cluster running with 3 masters and 1 agent, run some CLI commands successfully.
Thanks,
Armand Grillet
Re: Review Request 62938: Added ZooKeeper leader resolution to CLI.
Posted by Eric Chung <ci...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62938/#review189445
-----------------------------------------------------------
Ship it!
Ship It!
- Eric Chung
On Oct. 26, 2017, 4:52 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62938/
> -----------------------------------------------------------
>
> (Updated Oct. 26, 2017, 4:52 p.m.)
>
>
> Review request for mesos, Eric Chung and Kevin Klues.
>
>
> Bugs: MESOS-8012
> https://issues.apache.org/jira/browse/MESOS-8012
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change allows users to use the CLI with a Mesos running in high
> availability mode. The `zookeeper` field was already here before this
> commit, with an `addresses` array and a `path` field. This change
> only adds the backend to actually make it usable.
>
> Interacting with ZooKeeper requires a new dependency, kazoo, that has
> been added to the list of requirements for the CLI.
>
>
> Diffs
> -----
>
> src/python/cli_new/README.md a4b270d9b54cdd83bd62530fb44ddfaffb8a014b
> src/python/cli_new/lib/cli/util.py dd109c09368e650b7d7dabd663c11bc2e3e5180a
> src/python/cli_new/pip-requirements.txt 7aeac344c47ccd2588fded44d7314db7abd85653
>
>
> Diff: https://reviews.apache.org/r/62938/diff/3/
>
>
> Testing
> -------
>
> Tested with a Mesos cluster running with 3 masters and 1 agent, run some CLI commands successfully.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 62938: Added ZooKeeper leader resolution to CLI.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62938/#review189402
-----------------------------------------------------------
Patch looks great!
Reviews applied: [62938]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Oct. 26, 2017, 4:52 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62938/
> -----------------------------------------------------------
>
> (Updated Oct. 26, 2017, 4:52 p.m.)
>
>
> Review request for mesos, Eric Chung and Kevin Klues.
>
>
> Bugs: MESOS-8012
> https://issues.apache.org/jira/browse/MESOS-8012
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change allows users to use the CLI with a Mesos running in high
> availability mode. The `zookeeper` field was already here before this
> commit, with an `addresses` array and a `path` field. This change
> only adds the backend to actually make it usable.
>
> Interacting with ZooKeeper requires a new dependency, kazoo, that has
> been added to the list of requirements for the CLI.
>
>
> Diffs
> -----
>
> src/python/cli_new/README.md a4b270d9b54cdd83bd62530fb44ddfaffb8a014b
> src/python/cli_new/lib/cli/util.py dd109c09368e650b7d7dabd663c11bc2e3e5180a
> src/python/cli_new/pip-requirements.txt 7aeac344c47ccd2588fded44d7314db7abd85653
>
>
> Diff: https://reviews.apache.org/r/62938/diff/2/
>
>
> Testing
> -------
>
> Tested with a Mesos cluster running with 3 masters and 1 agent, run some CLI commands successfully.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 62938: Added ZooKeeper leader resolution to CLI.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62938/#review189372
-----------------------------------------------------------
PASS: Mesos patch 62938 was successfully built and tested.
Reviews applied: `['62938']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62938
- Mesos Reviewbot Windows
On Oct. 26, 2017, 4:52 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62938/
> -----------------------------------------------------------
>
> (Updated Oct. 26, 2017, 4:52 p.m.)
>
>
> Review request for mesos, Eric Chung and Kevin Klues.
>
>
> Bugs: MESOS-8012
> https://issues.apache.org/jira/browse/MESOS-8012
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change allows users to use the CLI with a Mesos running in high
> availability mode. The `zookeeper` field was already here before this
> commit, with an `addresses` array and a `path` field. This change
> only adds the backend to actually make it usable.
>
> Interacting with ZooKeeper requires a new dependency, kazoo, that has
> been added to the list of requirements for the CLI.
>
>
> Diffs
> -----
>
> src/python/cli_new/README.md a4b270d9b54cdd83bd62530fb44ddfaffb8a014b
> src/python/cli_new/lib/cli/util.py dd109c09368e650b7d7dabd663c11bc2e3e5180a
> src/python/cli_new/pip-requirements.txt 7aeac344c47ccd2588fded44d7314db7abd85653
>
>
> Diff: https://reviews.apache.org/r/62938/diff/2/
>
>
> Testing
> -------
>
> Tested with a Mesos cluster running with 3 masters and 1 agent, run some CLI commands successfully.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 62938: Added ZooKeeper leader resolution to CLI.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62938/#review189436
-----------------------------------------------------------
Patch looks great!
Reviews applied: [62938]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Oct. 26, 2017, 4:52 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62938/
> -----------------------------------------------------------
>
> (Updated Oct. 26, 2017, 4:52 p.m.)
>
>
> Review request for mesos, Eric Chung and Kevin Klues.
>
>
> Bugs: MESOS-8012
> https://issues.apache.org/jira/browse/MESOS-8012
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change allows users to use the CLI with a Mesos running in high
> availability mode. The `zookeeper` field was already here before this
> commit, with an `addresses` array and a `path` field. This change
> only adds the backend to actually make it usable.
>
> Interacting with ZooKeeper requires a new dependency, kazoo, that has
> been added to the list of requirements for the CLI.
>
>
> Diffs
> -----
>
> src/python/cli_new/README.md a4b270d9b54cdd83bd62530fb44ddfaffb8a014b
> src/python/cli_new/lib/cli/util.py dd109c09368e650b7d7dabd663c11bc2e3e5180a
> src/python/cli_new/pip-requirements.txt 7aeac344c47ccd2588fded44d7314db7abd85653
>
>
> Diff: https://reviews.apache.org/r/62938/diff/3/
>
>
> Testing
> -------
>
> Tested with a Mesos cluster running with 3 masters and 1 agent, run some CLI commands successfully.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 62938: Added ZooKeeper leader resolution to CLI.
Posted by Eric Chung <ci...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62938/#review189321
-----------------------------------------------------------
src/python/cli_new/lib/cli/util.py
Lines 247-253 (patched)
<https://reviews.apache.org/r/62938/#comment266333>
why not just use list comprehension?
src/python/cli_new/lib/cli/util.py
Lines 257 (patched)
<https://reviews.apache.org/r/62938/#comment266334>
why not just use `if not json_data`?
- Eric Chung
On Oct. 26, 2017, 4:52 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62938/
> -----------------------------------------------------------
>
> (Updated Oct. 26, 2017, 4:52 p.m.)
>
>
> Review request for mesos, Eric Chung and Kevin Klues.
>
>
> Bugs: MESOS-8012
> https://issues.apache.org/jira/browse/MESOS-8012
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change allows users to use the CLI with a Mesos running in high
> availability mode. The `zookeeper` field was already here before this
> commit, with an `addresses` array and a `path` field. This change
> only adds the backend to actually make it usable.
>
> Interacting with ZooKeeper requires a new dependency, kazoo, that has
> been added to the list of requirements for the CLI.
>
>
> Diffs
> -----
>
> src/python/cli_new/README.md a4b270d9b54cdd83bd62530fb44ddfaffb8a014b
> src/python/cli_new/lib/cli/util.py dd109c09368e650b7d7dabd663c11bc2e3e5180a
> src/python/cli_new/pip-requirements.txt 7aeac344c47ccd2588fded44d7314db7abd85653
>
>
> Diff: https://reviews.apache.org/r/62938/diff/2/
>
>
> Testing
> -------
>
> Tested with a Mesos cluster running with 3 masters and 1 agent, run some CLI commands successfully.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 62938: Added ZooKeeper leader resolution to CLI.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62938/#review190322
-----------------------------------------------------------
src/python/cli_new/lib/cli/util.py
Lines 258 (patched)
<https://reviews.apache.org/r/62938/#comment267611>
We don't need this if statement. At a minimum we will get a "{}" back from the zk.get() call (which will make this if statement always return true.
src/python/cli_new/lib/cli/util.py
Lines 266 (patched)
<https://reviews.apache.org/r/62938/#comment267614>
Let's pull the zk.stop() up above the if statememnt here and wrap it in a try/except block.
Then we can do the if/return followed immediately by the raise on failure.
src/python/cli_new/lib/cli/util.py
Lines 270 (patched)
<https://reviews.apache.org/r/62938/#comment267607>
Can this throw an exception?
- Kevin Klues
On Oct. 26, 2017, 4:52 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62938/
> -----------------------------------------------------------
>
> (Updated Oct. 26, 2017, 4:52 p.m.)
>
>
> Review request for mesos, Eric Chung and Kevin Klues.
>
>
> Bugs: MESOS-8012
> https://issues.apache.org/jira/browse/MESOS-8012
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change allows users to use the CLI with a Mesos running in high
> availability mode. The `zookeeper` field was already here before this
> commit, with an `addresses` array and a `path` field. This change
> only adds the backend to actually make it usable.
>
> Interacting with ZooKeeper requires a new dependency, kazoo, that has
> been added to the list of requirements for the CLI.
>
>
> Diffs
> -----
>
> src/python/cli_new/README.md a4b270d9b54cdd83bd62530fb44ddfaffb8a014b
> src/python/cli_new/lib/cli/util.py dd109c09368e650b7d7dabd663c11bc2e3e5180a
> src/python/cli_new/pip-requirements.txt 7aeac344c47ccd2588fded44d7314db7abd85653
>
>
> Diff: https://reviews.apache.org/r/62938/diff/4/
>
>
> Testing
> -------
>
> Tested with a Mesos cluster running with 3 masters and 1 agent, run some CLI commands successfully.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 62938: Added ZooKeeper leader resolution to CLI.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62938/#review190157
-----------------------------------------------------------
src/python/cli_new/lib/cli/util.py
Line 225 (original), 227 (patched)
<https://reviews.apache.org/r/62938/#comment267409>
Can you please remove the second sentence here. It seems unnecessary.
src/python/cli_new/lib/cli/util.py
Lines 233 (patched)
<https://reviews.apache.org/r/62938/#comment267408>
We don't need this anymore.
src/python/cli_new/lib/cli/util.py
Lines 235 (patched)
<https://reviews.apache.org/r/62938/#comment267410>
Do we need a try/except block here? We can wrap the whole Kazoo initialization in a single one and print the corresponding error.
src/python/cli_new/lib/cli/util.py
Lines 240-245 (patched)
<https://reviews.apache.org/r/62938/#comment267417>
We usually just catch an "Exception" and then let the error string indicate to us what went wrong.
src/python/cli_new/lib/cli/util.py
Lines 246 (patched)
<https://reviews.apache.org/r/62938/#comment267411>
We should probably have a catchall "Exception" caught here in case we throw an exception for any other reason.
src/python/cli_new/lib/cli/util.py
Lines 252 (patched)
<https://reviews.apache.org/r/62938/#comment267413>
I feel like we need a try catch around this whole thing, with the error prefix string saying something like: "Unable to communicate with mesos master using ZK: {error}"
src/python/cli_new/lib/cli/util.py
Lines 253 (patched)
<https://reviews.apache.org/r/62938/#comment267416>
This could throw an exception that we need to catch.
src/python/cli_new/lib/cli/util.py
Lines 255 (patched)
<https://reviews.apache.org/r/62938/#comment267414>
This could throw an exception that we need to catch.
src/python/cli_new/lib/cli/util.py
Lines 258 (patched)
<https://reviews.apache.org/r/62938/#comment267415>
This could throw an exception that we need to catch.
- Kevin Klues
On Oct. 26, 2017, 4:52 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62938/
> -----------------------------------------------------------
>
> (Updated Oct. 26, 2017, 4:52 p.m.)
>
>
> Review request for mesos, Eric Chung and Kevin Klues.
>
>
> Bugs: MESOS-8012
> https://issues.apache.org/jira/browse/MESOS-8012
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change allows users to use the CLI with a Mesos running in high
> availability mode. The `zookeeper` field was already here before this
> commit, with an `addresses` array and a `path` field. This change
> only adds the backend to actually make it usable.
>
> Interacting with ZooKeeper requires a new dependency, kazoo, that has
> been added to the list of requirements for the CLI.
>
>
> Diffs
> -----
>
> src/python/cli_new/README.md a4b270d9b54cdd83bd62530fb44ddfaffb8a014b
> src/python/cli_new/lib/cli/util.py dd109c09368e650b7d7dabd663c11bc2e3e5180a
> src/python/cli_new/pip-requirements.txt 7aeac344c47ccd2588fded44d7314db7abd85653
>
>
> Diff: https://reviews.apache.org/r/62938/diff/3/
>
>
> Testing
> -------
>
> Tested with a Mesos cluster running with 3 masters and 1 agent, run some CLI commands successfully.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 62938: Added ZooKeeper leader resolution to CLI.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62938/#review190244
-----------------------------------------------------------
PASS: Mesos patch 62938 was successfully built and tested.
Reviews applied: `['62938']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62938
- Mesos Reviewbot Windows
On Oct. 26, 2017, 4:52 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62938/
> -----------------------------------------------------------
>
> (Updated Oct. 26, 2017, 4:52 p.m.)
>
>
> Review request for mesos, Eric Chung and Kevin Klues.
>
>
> Bugs: MESOS-8012
> https://issues.apache.org/jira/browse/MESOS-8012
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change allows users to use the CLI with a Mesos running in high
> availability mode. The `zookeeper` field was already here before this
> commit, with an `addresses` array and a `path` field. This change
> only adds the backend to actually make it usable.
>
> Interacting with ZooKeeper requires a new dependency, kazoo, that has
> been added to the list of requirements for the CLI.
>
>
> Diffs
> -----
>
> src/python/cli_new/README.md a4b270d9b54cdd83bd62530fb44ddfaffb8a014b
> src/python/cli_new/lib/cli/util.py dd109c09368e650b7d7dabd663c11bc2e3e5180a
> src/python/cli_new/pip-requirements.txt 7aeac344c47ccd2588fded44d7314db7abd85653
>
>
> Diff: https://reviews.apache.org/r/62938/diff/3/
>
>
> Testing
> -------
>
> Tested with a Mesos cluster running with 3 masters and 1 agent, run some CLI commands successfully.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 62938: Added ZooKeeper leader resolution to CLI.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62938/#review190327
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Klues
On Nov. 7, 2017, 3:50 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62938/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2017, 3:50 p.m.)
>
>
> Review request for mesos, Eric Chung and Kevin Klues.
>
>
> Bugs: MESOS-8012
> https://issues.apache.org/jira/browse/MESOS-8012
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change allows users to use the CLI with a Mesos running in high
> availability mode. The `zookeeper` field was already here before this
> commit, with an `addresses` array and a `path` field. This change
> only adds the backend to actually make it usable.
>
> Interacting with ZooKeeper requires a new dependency, kazoo, that has
> been added to the list of requirements for the CLI.
>
>
> Diffs
> -----
>
> src/python/cli_new/README.md a4b270d9b54cdd83bd62530fb44ddfaffb8a014b
> src/python/cli_new/lib/cli/util.py dd109c09368e650b7d7dabd663c11bc2e3e5180a
> src/python/cli_new/pip-requirements.txt 7aeac344c47ccd2588fded44d7314db7abd85653
>
>
> Diff: https://reviews.apache.org/r/62938/diff/5/
>
>
> Testing
> -------
>
> Tested with a Mesos cluster running with 3 masters and 1 agent, run some CLI commands successfully.
>
> To use Mesos in HAM locally I have done (on macOS):
> ```
> zkServer start
> bash mesos-master.sh --port='5061' --zk='zk://127.0.0.1:2181/mesos' --work_dir='/tmp/master1' --quorum=1
> bash mesos-master.sh --port='5062' --zk='zk://127.0.0.1:2181/mesos' --work_dir='/tmp/master2' --quorum=1
> bash mesos-master.sh --port='5063' --zk='zk://127.0.0.1:2181/mesos' --work_dir='/tmp/master3' --quorum=1
> bash mesos-agent.sh --master='zk://127.0.0.1:2181/mesos' --work_dir='/tmp/agent'
> ```
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 62938: Added ZooKeeper leader resolution to CLI.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62938/
-----------------------------------------------------------
(Updated Nov. 7, 2017, 3:50 p.m.)
Review request for mesos, Eric Chung and Kevin Klues.
Changes
-------
Fixed issues.
Bugs: MESOS-8012
https://issues.apache.org/jira/browse/MESOS-8012
Repository: mesos
Description (updated)
-------
This change allows users to use the CLI with a Mesos running in high
availability mode. The `zookeeper` field was already here before this
commit, with an `addresses` array and a `path` field. This change
only adds the backend to actually make it usable.
Interacting with ZooKeeper requires a new dependency, kazoo, that has
been added to the list of requirements for the CLI.
Diffs (updated)
-----
src/python/cli_new/README.md a4b270d9b54cdd83bd62530fb44ddfaffb8a014b
src/python/cli_new/lib/cli/util.py dd109c09368e650b7d7dabd663c11bc2e3e5180a
src/python/cli_new/pip-requirements.txt 7aeac344c47ccd2588fded44d7314db7abd85653
Diff: https://reviews.apache.org/r/62938/diff/5/
Changes: https://reviews.apache.org/r/62938/diff/4-5/
Testing
-------
Tested with a Mesos cluster running with 3 masters and 1 agent, run some CLI commands successfully.
Thanks,
Armand Grillet
Re: Review Request 62938: Added ZooKeeper leader resolution to CLI.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62938/
-----------------------------------------------------------
(Updated Oct. 26, 2017, 4:52 p.m.)
Review request for mesos, Eric Chung and Kevin Klues.
Changes
-------
Sorted nodes.
Bugs: MESOS-8012
https://issues.apache.org/jira/browse/MESOS-8012
Repository: mesos
Description (updated)
-------
This change allows users to use the CLI with a Mesos running in high
availability mode. The `zookeeper` field was already here before this
commit, with an `addresses` array and a `path` field. This change
only adds the backend to actually make it usable.
Interacting with ZooKeeper requires a new dependency, kazoo, that has
been added to the list of requirements for the CLI.
Diffs (updated)
-----
src/python/cli_new/README.md a4b270d9b54cdd83bd62530fb44ddfaffb8a014b
src/python/cli_new/lib/cli/util.py dd109c09368e650b7d7dabd663c11bc2e3e5180a
src/python/cli_new/pip-requirements.txt 7aeac344c47ccd2588fded44d7314db7abd85653
Diff: https://reviews.apache.org/r/62938/diff/2/
Changes: https://reviews.apache.org/r/62938/diff/1-2/
Testing
-------
Tested with a Mesos cluster running with 3 masters and 1 agent, run some CLI commands successfully.
Thanks,
Armand Grillet
Re: Review Request 62938: Added ZooKeeper leader resolution to CLI.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62938/#review187907
-----------------------------------------------------------
Patch looks great!
Reviews applied: [62938]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Oct. 12, 2017, 5:01 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62938/
> -----------------------------------------------------------
>
> (Updated Oct. 12, 2017, 5:01 p.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Bugs: MESOS-8012
> https://issues.apache.org/jira/browse/MESOS-8012
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change allows using the CLI with a Mesos running in high
> availability mode. The `zookeeper` field was present before this
> meeting, with an `addresses` array and a `path` field. This change
> only adds the backend to actually make it usable.
>
> Interacting with ZooKeeper requires a new dependency, kazoo, that has
> been added to the list of requirements for the CLI.
>
>
> Diffs
> -----
>
> src/python/cli_new/README.md a4b270d9b54cdd83bd62530fb44ddfaffb8a014b
> src/python/cli_new/lib/cli/util.py dd109c09368e650b7d7dabd663c11bc2e3e5180a
> src/python/cli_new/pip-requirements.txt 7aeac344c47ccd2588fded44d7314db7abd85653
>
>
> Diff: https://reviews.apache.org/r/62938/diff/1/
>
>
> Testing
> -------
>
> Tested with a Mesos cluster running with 3 masters and 1 agent, run some CLI commands successfully.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 62938: Added ZooKeeper leader resolution to CLI.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62938/#review187852
-----------------------------------------------------------
FAIL: Some Mesos tests failed.
Reviews applied: `['62938']`
Failed command: `C:\mesos\src\mesos-tests.exe --verbose --gtest_filter="-ContentType/MasterAPITest.EventAuthorizationFiltering/1"`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62938
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62938/logs/mesos-tests-stdout.log):
```
[ OK ] Endpoint/SlaveEndpointTest.UnauthorizedRequest/0 (288 ms)
[ RUN ] Endpoint/SlaveEndpointTest.UnauthorizedRequest/1
[ OK ] Endpoint/SlaveEndpointTest.UnauthorizedRequest/1 (286 ms)
[ RUN ] Endpoint/SlaveEndpointTest.UnauthorizedRequest/2
[ OK ] Endpoint/SlaveEndpointTest.UnauthorizedRequest/2 (306 ms)
[ RUN ] Endpoint/SlaveEndpointTest.NoAuthorizer/0
[ OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/0 (296 ms)
[ RUN ] Endpoint/SlaveEndpointTest.NoAuthorizer/1
[ OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/1 (317 ms)
[ RUN ] Endpoint/SlaveEndpointTest.NoAuthorizer/2
[ OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (294 ms)
[----------] 9 tests from Endpoint/SlaveEndpointTest (3090 ms total)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (137 ms)
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (154 ms)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (338 ms total)
[----------] Global test environment tear-down
[==========] 723 tests from 73 test cases ran. (375631 ms total)
[ PASSED ] 722 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] MesosContainerizer/DefaultExecutorTest.ROOT_ContainerStatusForTask/0, where GetParam() = "mesos"
1 FAILED TEST
YOU HAVE 165 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62938/logs/mesos-tests-stderr.log):
```
I1012 19:37:43.896373 4348 containerizer.cpp:648] Recovering containerizer
I1012 19:37:43.903381 50400 provisioner.cpp:416] Provisioner recovery complete
I1012 19:37:43.904374 49720 slave.cpp:6310] Finished recovery
I1012 19:37:43.924374 47560 http.cpp:1185] HTTP GET for /slave(270)/monitor/statistics.json from 10.3.1.7:55688
I1012 19:37:43.952787 47560 http.cpp:976] Authorizing principal 'test-principal' to GET the '/monitor/statistics.json' endpoint
I1012 19:37:43.972789 52160 slave.cpp:869] Agent terminating
I1012 19:37:44.125808 51348 containerizer.cpp:292] Using isolation { windows/cpu, filesystem/windows, environment_secret }
I1012 19:37:44.128809 51348 provisioner.cpp:255] Using default backend 'copy'
I1012 19:37:44.145809 51348 cluster.cpp:448] Creating default 'local' authorizer
I1012 19:37:44.168810 4348 slave.cpp:254] Mesos agent started on (271)@10.3.1.7:54757
I1012 19:37:44.168810 4348 slave.cpp:255] Flags at startup: --acls="" --appc_simple_discovery_uri_prefix="http://" --appc_store_dir="C:\Users\mesos\AppData\Local\Temp\2\7pQXLL\store\appc" --authenticate_http_readonly="true" --authenticate_http_readwrite="true" --authenticatee="crammd5" --authentication_backoff_factor="1secs" --authorizer="local" --container_disk_watch_interval="15secs" --containerizers="mesos" --credential="C:\Users\mesos\AppData\Local\Temp\2\7pQXLL\credential" --default_role="*" --disk_watch_interval="1mins" --docker="docker" --docker_kill_orphans="true" --docker_registry="https://registry-1.docker.io" --docker_remove_delay="6hrs" --docker_socket="//./pipe/docker_engine" --docker_stop_timeout="0ns" --docker_store_dir="C:\Users\mesos\AppData\Local\Temp\2\7pQXLL\store\docker" --docker_volume_checkpoint_dir="/var/run/mesos/isolators/docker/volume" --enforce_container_disk_quota="false" --executor_registration_timeout="1mins" --executor_reregistration_timeout="2secs" -
-executor_shutdown_grace_period="5secs" --fetcher_cache_dir="C:\Users\mesos\AppData\Local\Temp\2\7pQXLL\fetch" --fetcher_cache_size="2GB" --frameworks_home="" --gc_delay="1weeks" --gc_disk_headroom="0.1" --hadoop_home="" --help="false" --hostname_lookup="true" --http_command_executor="false" --http_credentials="C:\Users\mesos\AppData\Local\Temp\2\7pQXLL\http_credentials" --http_heartbeat_interval="30secs" --initialize_driver_logging="true" --isolation="windows/cpu" --launcher="windows" --launcher_dir="C:\mesos\src" --logbufsecs="0" --logging_level="INFO" --max_completed_executors_per_framework="150" --oversubscribed_resources_interval="15secs" --port="5051" --qos_correction_interval_min="0ns" --quiet="false" --recover="reconnect" --recovery_timeout="15mins" --registration_backoff_factor="10ms" --resources="cpus:2;gpus:0;mem:1024;disk:1024;ports:[31000-32000]" --runtime_dir="C:\Users\mesos\AppData\Local\Temp\2\7pQXLL" --sandbox_directory="C:\mesos\sandbox" --strict="true" --version="
false" --work_dir="C:\Users\mesos\AppData\Local\Temp\2\dB7TOL" --zk_session_timeout="10secs"
I1012 19:37:44.200814 4348 credentials.hpp:86] Loading credential for authentication from 'C:\Users\mesos\AppData\Local\Temp\2\7pQXLL\credential'
I1012 19:37:44.201812 4348 slave.cpp:287] Agent using credential for: test-principal
I1012 19:37:44.202811 4348 credentials.hpp:37] Loading credentials for authentication from 'C:\Users\mesos\AppData\Local\Temp\2\7pQXLL\http_credentials'
I1012 19:37:44.213810 4348 http.cpp:1045] Creating default 'basic' HTTP authenticator for realm 'mesos-agent-readonly'
I1012 19:37:44.215812 4348 http.cpp:1045] Creating default 'basic' HTTP authenticator for realm 'mesos-agent-readwrite'
I1012 19:37:44.226811 4348 slave.cpp:585] Agent resources: [{"name":"cpus","scalar":{"value":2.0},"type":"SCALAR"},{"name":"mem","scalar":{"value":1024.0},"type":"SCALAR"},{"name":"disk","scalar":{"value":1024.0},"type":"SCALAR"},{"name":"ports","ranges":{"range":[{"begin":31000,"end":32000}]},"type":"RANGES"}]
I1012 19:37:44.231814 4348 slave.cpp:593] Agent attributes: [ ]
I1012 19:37:44.231814 4348 slave.cpp:602] Agent hostname: mesos-bld-s2.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I1012 19:37:44.231814 47560 status_update_manager.cpp:177] Pausing sending status updates
I1012 19:37:44.241814 50092 state.cpp:64] Recovering state from 'C:\Users\mesos\AppData\Local\Temp\2\dB7TOL\meta'
I1012 19:37:44.242811 50400 status_update_manager.cpp:203] Recovering status update manager
I1012 19:37:44.255812 52160 containerizer.cpp:648] Recovering containerizer
I1012 19:37:44.262814 4348 provisioner.cpp:416] Provisioner recovery complete
I1012 19:37:44.264813 41652 slave.cpp:6310] Finished recovery
I1012 19:37:44.283813 4348 http.cpp:1185] HTTP GET for /slave(271)/containers from 10.3.1.7:55689
I1012 19:37:44.283813 4348 http.cpp:976] Authorizing principal 'test-principal' to GET the '/containers' endpoint
I1012 19:37:44.311815 51348 slave.cpp:869] Agent terminating
I1012 19:37:45.342258 51980 process.cpp:1068] Failed to accept socket: future discarded
```
- Mesos Reviewbot Windows
On Oct. 12, 2017, 5:01 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62938/
> -----------------------------------------------------------
>
> (Updated Oct. 12, 2017, 5:01 p.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Bugs: MESOS-8012
> https://issues.apache.org/jira/browse/MESOS-8012
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change allows using the CLI with a Mesos running in high
> availability mode. The `zookeeper` field was present before this
> meeting, with an `addresses` array and a `path` field. This change
> only adds the backend to actually make it usable.
>
> Interacting with ZooKeeper requires a new dependency, kazoo, that has
> been added to the list of requirements for the CLI.
>
>
> Diffs
> -----
>
> src/python/cli_new/README.md a4b270d9b54cdd83bd62530fb44ddfaffb8a014b
> src/python/cli_new/lib/cli/util.py dd109c09368e650b7d7dabd663c11bc2e3e5180a
> src/python/cli_new/pip-requirements.txt 7aeac344c47ccd2588fded44d7314db7abd85653
>
>
> Diff: https://reviews.apache.org/r/62938/diff/1/
>
>
> Testing
> -------
>
> Tested with a Mesos cluster running with 3 masters and 1 agent, run some CLI commands successfully.
>
>
> Thanks,
>
> Armand Grillet
>
>