You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2017/03/21 14:38:41 UTC

Review Request 57808: Updated the default executor to authenticate with the agent.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57808/
-----------------------------------------------------------

Review request for mesos, Anand Mazumdar, Alexander Rojas, and Vinod Kone.


Bugs: MESOS-6304
    https://issues.apache.org/jira/browse/MESOS-6304


Repository: mesos


Description
-------

This patch updates the default executor to extract
an authentication token from its environment when present,
and use this token to authenticate with the agent.


Diffs
-----

  src/launcher/default_executor.cpp cbd4f7ecd042e7fa603bd69774d95472df2c896d 


Diff: https://reviews.apache.org/r/57808/diff/1/


Testing
-------

Testing details can be found at the end of this patch chain.


Thanks,

Greg Mann


Re: Review Request 57808: Updated the default executor to authenticate with the agent.

Posted by Anand Mazumdar <an...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57808/#review169554
-----------------------------------------------------------


Ship it!




Ship It!

- Anand Mazumdar


On March 21, 2017, 2:38 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57808/
> -----------------------------------------------------------
> 
> (Updated March 21, 2017, 2:38 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Alexander Rojas, and Vinod Kone.
> 
> 
> Bugs: MESOS-6304
>     https://issues.apache.org/jira/browse/MESOS-6304
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch updates the default executor to extract
> an authentication token from its environment when present,
> and use this token to authenticate with the agent.
> 
> 
> Diffs
> -----
> 
>   src/launcher/default_executor.cpp cbd4f7ecd042e7fa603bd69774d95472df2c896d 
> 
> 
> Diff: https://reviews.apache.org/r/57808/diff/1/
> 
> 
> Testing
> -------
> 
> Testing details can be found at the end of this patch chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Re: Review Request 57808: Added support for auth tokens to the default executor.

Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57808/
-----------------------------------------------------------

(Updated March 22, 2017, 2:41 p.m.)


Review request for mesos, Anand Mazumdar, Alexander Rojas, and Vinod Kone.


Summary (updated)
-----------------

Added support for auth tokens to the default executor.


Bugs: MESOS-6304
    https://issues.apache.org/jira/browse/MESOS-6304


Repository: mesos


Description
-------

This patch updates the default executor to extract
an authentication token from its environment when present,
and use this token to authenticate with the agent.


Diffs (updated)
-----

  src/launcher/default_executor.cpp 6a885af50db6d489194cc9b780fcf1494e853694 


Diff: https://reviews.apache.org/r/57808/diff/2/

Changes: https://reviews.apache.org/r/57808/diff/1-2/


Testing
-------

Testing details can be found at the end of this patch chain.


Thanks,

Greg Mann