[GitHub] [airflow] eladkal commented on a change in pull request #14960: Support all terminus task states in Docker Swarm Operator

[GitBox <gi...@apache.org>]

eladkal commented on a change in pull request #14960:
URL: https://github.com/apache/airflow/pull/14960#discussion_r606830147



##########
File path: tests/providers/docker/operators/test_docker_swarm.py
##########
@@ -165,7 +165,7 @@ def test_failed_service_raises_error(self, types_mock, client_class_mock):
         client_class_mock.return_value = client_mock
 
         operator = DockerSwarmOperator(image='', auto_remove=False, task_id='unittest', enable_logging=False)
-        msg = "Service failed: {'ID': 'some_id'}"
+        msg = "Service did not complete: {'ID': 'some_id'}"

Review comment:
       Currently the operator has coverage only for `complete`/`failed` statuses.
   Since this PR adds more statuses should we maybe rename this test from `test_failed_service_raises_error` to `test_failure_service_raises_error` and make it parametrized with `['failed', 'shutdown', 'rejected', 'orphaned', 'remove']` ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org