You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/02/23 07:17:37 UTC
[GitHub] [apisix-dashboard] Jaycean opened a new issue #1500: Feat: Rewrite all E2E tests using the Ginkgo
Jaycean opened a new issue #1500:
URL: https://github.com/apache/apisix-dashboard/issues/1500
# Feature request
Rewrite all E2E tests using the Ginkgo.
There are a lot of E2E tests that need to be rewritten, so we record the rewriting of E2E in this issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal commented on issue #1500: Feat: Rewrite all E2E tests using the Ginkgo
Posted by GitBox <gi...@apache.org>.
bisakhmondal commented on issue #1500:
URL: https://github.com/apache/apisix-dashboard/issues/1500#issuecomment-797503039
Hey @Jaycean, I have rewritten the test using ginkgo for the mentioned test suite. Now I am facing issues to test it locally before opening a PR. I am following [the doc](https://github.com/apache/apisix-dashboard/blob/master/docs/en/latest/back-end-e2e.md) to set up the environment for the testing using docker-compose. It's failing, so opened issue #1581. It seems, for now, its better to go with installing the required dependencies locally. Pushing the changes soon :) Thank you
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #1500: Feat: Rewrite all E2E tests using the Ginkgo
Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #1500:
URL: https://github.com/apache/apisix-dashboard/issues/1500#issuecomment-783974256
Thanks @Jaycean
I think we could list a todo list by module
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] Jaycean edited a comment on issue #1500: Feat: Rewrite all E2E tests using the Ginkgo
Posted by GitBox <gi...@apache.org>.
Jaycean edited a comment on issue #1500:
URL: https://github.com/apache/apisix-dashboard/issues/1500#issuecomment-783995871
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] Jaycean commented on issue #1500: Feat: Rewrite all E2E tests using the Ginkgo
Posted by GitBox <gi...@apache.org>.
Jaycean commented on issue #1500:
URL: https://github.com/apache/apisix-dashboard/issues/1500#issuecomment-783995871
I think we can add the name of the person who is rewriting the file after each todolist, so as to avoid repeated development.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] Jaycean commented on issue #1500: Feat: Rewrite all E2E tests using the Ginkgo
Posted by GitBox <gi...@apache.org>.
Jaycean commented on issue #1500:
URL: https://github.com/apache/apisix-dashboard/issues/1500#issuecomment-797544726
> Hey @Jaycean, I have rewritten the test using ginkgo for the mentioned test suite. Now I am facing issues to test it locally before opening a PR. I am following [the doc](https://github.com/apache/apisix-dashboard/blob/master/docs/en/latest/back-end-e2e.md) to set up the environment for the testing using docker-compose. It's failing, so opened issue #1581. It seems, for now, its better to go with installing the required dependencies locally. Pushing the changes soon :) Thank you
Thank you for your contribution. I have replied to you in issue. If you have more questions, you can ask them in issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal commented on issue #1500: Feat: Rewrite all E2E tests using the Ginkgo
Posted by GitBox <gi...@apache.org>.
bisakhmondal commented on issue #1500:
URL: https://github.com/apache/apisix-dashboard/issues/1500#issuecomment-796499085
Hi @Jaycean, would you mind if I rewrite the `route import test` in the e2enew test suite :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on issue #1500: Feat: Rewrite all E2E tests using the Ginkgo
Posted by GitBox <gi...@apache.org>.
starsz commented on issue #1500:
URL: https://github.com/apache/apisix-dashboard/issues/1500#issuecomment-783971732
Yeah. Much appreciated.
As far as I know, @nic-chen had finished part of them but hadn't created PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] Jaycean commented on issue #1500: Feat: Rewrite all E2E tests using the Ginkgo
Posted by GitBox <gi...@apache.org>.
Jaycean commented on issue #1500:
URL: https://github.com/apache/apisix-dashboard/issues/1500#issuecomment-796502504
> Hi @Jaycean, would you mind if I rewrite the `route import test` in the e2enew test suite :)
Thank you very much. It has been allocated in to do list. You can @ me if you have any questions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] Jaycean edited a comment on issue #1500: Feat: Rewrite all E2E tests using the Ginkgo
Posted by GitBox <gi...@apache.org>.
Jaycean edited a comment on issue #1500:
URL: https://github.com/apache/apisix-dashboard/issues/1500#issuecomment-783995871
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] Jaycean commented on issue #1500: Feat: Rewrite all E2E tests using the Ginkgo
Posted by GitBox <gi...@apache.org>.
Jaycean commented on issue #1500:
URL: https://github.com/apache/apisix-dashboard/issues/1500#issuecomment-783991309
> Thanks @Jaycean
> I think we could list a todo list by module
OK, I'll make the list by E2E test file name
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] Jaycean commented on issue #1500: Feat: Rewrite all E2E tests using the Ginkgo
Posted by GitBox <gi...@apache.org>.
Jaycean commented on issue #1500:
URL: https://github.com/apache/apisix-dashboard/issues/1500#issuecomment-783968106
The PR and issue of the completed E2E can be associated and recorded.
cc @nic-chen @starsz @imjoey
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org