You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Li Jing Qin (JIRA)" <ji...@apache.org> on 2009/02/09 10:46:59 UTC
[jira] Created: (HARMONY-6085) [eut][classlib][nio] - modKey in
SelectorImpl should set the new index key to the changed selectionkey
[eut][classlib][nio] - modKey in SelectorImpl should set the new index key to the changed selectionkey
------------------------------------------------------------------------------------------------------
Key: HARMONY-6085
URL: https://issues.apache.org/jira/browse/HARMONY-6085
Project: Harmony
Issue Type: Bug
Environment: linux
Reporter: Li Jing Qin
modKey do two things:
1. delkey
2. addKey
When the old selectionKey is readded, new index which is returned from the addkey should be set to this selectionkey.
If does not do so. two problems will occurred, during eut update test on the lunix
1. Delete the wrong selectionkey, which will cause the right selector.select() return RESOURCE NOT READY. More over it will cause the test case try lots of time to get the resource.
2. ArrayIndexOutOfBounds because of the wrong index.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-6085) [eut][classlib][nio] - modKey in
SelectorImpl should set the new index key to the changed selectionkey
Posted by "Li Jing Qin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709318#action_12709318 ]
Li Jing Qin commented on HARMONY-6085:
--------------------------------------
verified. Thanks regis.
> [eut][classlib][nio] - modKey in SelectorImpl should set the new index key to the changed selectionkey
> ------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-6085
> URL: https://issues.apache.org/jira/browse/HARMONY-6085
> Project: Harmony
> Issue Type: Bug
> Environment: linux
> Reporter: Li Jing Qin
> Assignee: Regis Xu
> Fix For: 5.0M10
>
> Attachments: HARMONY-6085.diff, org.eclipse.update.tests.core_linux.gtk.x86.html
>
>
> modKey do two things:
> 1. delkey
> 2. addKey
> When the old selectionKey is readded, new index which is returned from the addkey should be set to this selectionkey.
> If does not do so. two problems will occurred, during eut update test on the lunix
> 1. Delete the wrong selectionkey, which will cause the right selector.select() return RESOURCE NOT READY. More over it will cause the test case try lots of time to get the resource.
> 2. ArrayIndexOutOfBounds because of the wrong index.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HARMONY-6085) [eut][classlib][nio] - modKey in
SelectorImpl should set the new index key to the changed selectionkey
Posted by "Regis Xu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Regis Xu resolved HARMONY-6085.
-------------------------------
Resolution: Fixed
Fix Version/s: 5.0M10
Thanks Li Jing Qin.
Patch applied at r774685, please verify.
> [eut][classlib][nio] - modKey in SelectorImpl should set the new index key to the changed selectionkey
> ------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-6085
> URL: https://issues.apache.org/jira/browse/HARMONY-6085
> Project: Harmony
> Issue Type: Bug
> Environment: linux
> Reporter: Li Jing Qin
> Assignee: Regis Xu
> Fix For: 5.0M10
>
> Attachments: HARMONY-6085.diff, org.eclipse.update.tests.core_linux.gtk.x86.html
>
>
> modKey do two things:
> 1. delkey
> 2. addKey
> When the old selectionKey is readded, new index which is returned from the addkey should be set to this selectionkey.
> If does not do so. two problems will occurred, during eut update test on the lunix
> 1. Delete the wrong selectionkey, which will cause the right selector.select() return RESOURCE NOT READY. More over it will cause the test case try lots of time to get the resource.
> 2. ArrayIndexOutOfBounds because of the wrong index.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HARMONY-6085) [eut][classlib][nio] - modKey in
SelectorImpl should set the new index key to the changed selectionkey
Posted by "Regis Xu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Regis Xu reassigned HARMONY-6085:
---------------------------------
Assignee: Regis Xu
> [eut][classlib][nio] - modKey in SelectorImpl should set the new index key to the changed selectionkey
> ------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-6085
> URL: https://issues.apache.org/jira/browse/HARMONY-6085
> Project: Harmony
> Issue Type: Bug
> Environment: linux
> Reporter: Li Jing Qin
> Assignee: Regis Xu
> Attachments: HARMONY-6085.diff, org.eclipse.update.tests.core_linux.gtk.x86.html
>
>
> modKey do two things:
> 1. delkey
> 2. addKey
> When the old selectionKey is readded, new index which is returned from the addkey should be set to this selectionkey.
> If does not do so. two problems will occurred, during eut update test on the lunix
> 1. Delete the wrong selectionkey, which will cause the right selector.select() return RESOURCE NOT READY. More over it will cause the test case try lots of time to get the resource.
> 2. ArrayIndexOutOfBounds because of the wrong index.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-6085) [eut][classlib][nio] - modKey in
SelectorImpl should set the new index key to the changed selectionkey
Posted by "Li Jing Qin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Li Jing Qin updated HARMONY-6085:
---------------------------------
Attachment: HARMONY-6085.diff
In the patch I do two things:
1. Apply the new index to the selection Key
2. Break the ensureCapacity into three part: Common, Read and Write.
Because it is unusual for one selector being interested in both READ and WRITE ops in one time, these will help to save 2 System.arraycopy per selector action.
Would any one please to review it?
> [eut][classlib][nio] - modKey in SelectorImpl should set the new index key to the changed selectionkey
> ------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-6085
> URL: https://issues.apache.org/jira/browse/HARMONY-6085
> Project: Harmony
> Issue Type: Bug
> Environment: linux
> Reporter: Li Jing Qin
> Attachments: HARMONY-6085.diff
>
>
> modKey do two things:
> 1. delkey
> 2. addKey
> When the old selectionKey is readded, new index which is returned from the addkey should be set to this selectionkey.
> If does not do so. two problems will occurred, during eut update test on the lunix
> 1. Delete the wrong selectionkey, which will cause the right selector.select() return RESOURCE NOT READY. More over it will cause the test case try lots of time to get the resource.
> 2. ArrayIndexOutOfBounds because of the wrong index.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (HARMONY-6085) [eut][classlib][nio] - modKey in
SelectorImpl should set the new index key to the changed selectionkey
Posted by "Regis Xu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Regis Xu closed HARMONY-6085.
-----------------------------
> [eut][classlib][nio] - modKey in SelectorImpl should set the new index key to the changed selectionkey
> ------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-6085
> URL: https://issues.apache.org/jira/browse/HARMONY-6085
> Project: Harmony
> Issue Type: Bug
> Environment: linux
> Reporter: Li Jing Qin
> Assignee: Regis Xu
> Fix For: 5.0M10
>
> Attachments: HARMONY-6085.diff, org.eclipse.update.tests.core_linux.gtk.x86.html
>
>
> modKey do two things:
> 1. delkey
> 2. addKey
> When the old selectionKey is readded, new index which is returned from the addkey should be set to this selectionkey.
> If does not do so. two problems will occurred, during eut update test on the lunix
> 1. Delete the wrong selectionkey, which will cause the right selector.select() return RESOURCE NOT READY. More over it will cause the test case try lots of time to get the resource.
> 2. ArrayIndexOutOfBounds because of the wrong index.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-6085) [eut][classlib][nio] - modKey in
SelectorImpl should set the new index key to the changed selectionkey
Posted by "Li Jing Qin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Li Jing Qin updated HARMONY-6085:
---------------------------------
Attachment: org.eclipse.update.tests.core_linux.gtk.x86.html
Also I have attached the test result for update test in EUT.
> [eut][classlib][nio] - modKey in SelectorImpl should set the new index key to the changed selectionkey
> ------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-6085
> URL: https://issues.apache.org/jira/browse/HARMONY-6085
> Project: Harmony
> Issue Type: Bug
> Environment: linux
> Reporter: Li Jing Qin
> Attachments: HARMONY-6085.diff, org.eclipse.update.tests.core_linux.gtk.x86.html
>
>
> modKey do two things:
> 1. delkey
> 2. addKey
> When the old selectionKey is readded, new index which is returned from the addkey should be set to this selectionkey.
> If does not do so. two problems will occurred, during eut update test on the lunix
> 1. Delete the wrong selectionkey, which will cause the right selector.select() return RESOURCE NOT READY. More over it will cause the test case try lots of time to get the resource.
> 2. ArrayIndexOutOfBounds because of the wrong index.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.