You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Vaibhav Gumashta <vg...@hortonworks.com> on 2014/04/05 22:18:41 UTC
Review Request 20061: HiveServer2 thrift/http mode & binary mode proxy user
check fails reporting IP null for client
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20061/
-----------------------------------------------------------
Review request for hive, dilli dorai, Prasad Mujumdar, and Thejas Nair.
Bugs: HIVE-6837
https://issues.apache.org/jira/browse/HIVE-6837
Repository: hive-git
Description
-------
https://issues.apache.org/jira/browse/HIVE-6837
Diffs
-----
service/src/java/org/apache/hive/service/auth/HiveAuthFactory.java d8f4822
service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 046e4d9
service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpServlet.java 2bda9a4
Diff: https://reviews.apache.org/r/20061/diff/
Testing
-------
Using beeline on a secure cluster, running HS2 in http/binary modes.
Thanks,
Vaibhav Gumashta
Re: Review Request 20061: HiveServer2 thrift/http mode & binary mode proxy
user check fails reporting IP null for client
Posted by Vaibhav Gumashta <vg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20061/
-----------------------------------------------------------
(Updated April 6, 2014, 12:10 p.m.)
Review request for hive, dilli dorai, Prasad Mujumdar, and Thejas Nair.
Bugs: HIVE-6837
https://issues.apache.org/jira/browse/HIVE-6837
Repository: hive-git
Description
-------
https://issues.apache.org/jira/browse/HIVE-6837
Diffs (updated)
-----
service/src/java/org/apache/hive/service/auth/HiveAuthFactory.java d8f4822
service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 046e4d9
service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpServlet.java 2bda9a4
Diff: https://reviews.apache.org/r/20061/diff/
Testing
-------
Using beeline on a secure cluster, running HS2 in http/binary modes.
Thanks,
Vaibhav Gumashta
Re: Review Request 20061: HiveServer2 thrift/http mode & binary mode proxy
user check fails reporting IP null for client
Posted by dilli dorai <di...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20061/#review39646
-----------------------------------------------------------
service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java
<https://reviews.apache.org/r/20061/#comment72212>
Would recommend using LOG.debug instead of LOG.info
service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpServlet.java
<https://reviews.apache.org/r/20061/#comment72211>
request.getLocalAddr() would return local ip address. You have to use getRemoteAddr()
- dilli dorai
On April 5, 2014, 8:18 p.m., Vaibhav Gumashta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20061/
> -----------------------------------------------------------
>
> (Updated April 5, 2014, 8:18 p.m.)
>
>
> Review request for hive, dilli dorai, Prasad Mujumdar, and Thejas Nair.
>
>
> Bugs: HIVE-6837
> https://issues.apache.org/jira/browse/HIVE-6837
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/HIVE-6837
>
>
> Diffs
> -----
>
> service/src/java/org/apache/hive/service/auth/HiveAuthFactory.java d8f4822
> service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 046e4d9
> service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpServlet.java 2bda9a4
>
> Diff: https://reviews.apache.org/r/20061/diff/
>
>
> Testing
> -------
>
> Using beeline on a secure cluster, running HS2 in http/binary modes.
>
>
> Thanks,
>
> Vaibhav Gumashta
>
>