Re: svn commit: r354246 - /spamassassin/trunk/build/mkrules

[Justin Mason <jm...@jmason.org>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


Theo Van Dinter writes:
> On Tue, Dec 06, 2005 at 12:52:23AM -0000, jm@apache.org wrote:
> > -      if (-e $entry->{t}) {
> > +      # jm: we always want to update the output file in case the input
> > +      # has been changed!
> > +      if (0 && -e $entry->{t}) {
> >  	warn "The perl module ".$entry->{t}." already exists, can't copy from ".$entry->{f}."\n";
> >        }
> >        else {
> 
> The reason I did that was so in case multiple sandboxes had the same module
> name, the first wouldn't get overwritten.  But in that case something is going
> to fail so I guess it doesn't matter.

doh.  yes, I think it's going to be a limitation we can't avoid.

by the way there are still test failures: "t/recreate.t" is failing.  It
looks a lot like we have some fundamental bug there.

- --j.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Exmh CVS

iD8DBQFDlPY+MJF5cimLx9ARAuE1AJwNRJcGkZy7LGEqmOtKVeZmQNhNiACfbQjr
/gai2lvpf3foDOMZH74wECU=
=9RsQ
-----END PGP SIGNATURE-----