You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by re...@apache.org on 2009/01/06 16:33:11 UTC

svn commit: r731974 - /tomcat/tc6.0.x/trunk/STATUS.txt

Author: remm
Date: Tue Jan  6 07:33:11 2009
New Revision: 731974

URL: http://svn.apache.org/viewvc?rev=731974&view=rev
Log:
- Votes.

Modified:
    tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=731974&r1=731973&r2=731974&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Tue Jan  6 07:33:11 2009
@@ -222,7 +222,7 @@
   the JDBCRealm is invalid.
   Based on a patch by Owen Jacobson
   http://svn.apache.org/viewvc?rev=729809&view=rev
-  +1: markt
+  +1: markt, remm
   -1: 
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46261
@@ -247,20 +247,21 @@
 
 * Print user friendly message when attempting to shutdown and shutdown port is disabled
   http://svn.apache.org/viewvc?rev=730178&view=rev
-  +1: fhanik
+  +1: fhanik, remm
   -1:
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=36923
   If EL is disabled, treat it as template text
   http://svn.apache.org/viewvc?rev=730590&view=rev
   +1: markt
+   0: remm (needs TCK testing)
   -1: 
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46462
   Limit package test to just the o.a.jsp package to allow use of packages such
   as o.a.jspwiki
   http://svn.apache.org/viewvc?rev=730694&view=rev
-  +1: markt
+  +1: markt, remm
   -1: 
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=37458
@@ -274,10 +275,11 @@
   Use jar url and tag file path to uniquely ID a tag file to prevent naming
   clashes
   +1: markt
-  -1: 
+  -1: remm (e.printStackTrace in the patch, and maybe usage of URL constructs which could lead to issues
+            when not filesystem based; also needs TCK testing)
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=37515
   Add options for 1.6 and 1.7 source and target to JDT compiler
   http://svn.apache.org/viewvc?rev=731773&view=rev
-  +1: markt
+  +1: markt, remm
   -1: 



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: svn commit: r731974 - /tomcat/tc6.0.x/trunk/STATUS.txt

Posted by Remy Maucherat <re...@apache.org>.
On Tue, 2009-01-06 at 18:19 +0000, Mark Thomas wrote:
> Sorry - I'll fix the exception handling.
> The TCK passes for me.

Then I suppose it is ok. The new URL that is constructed is only used as
a String, right, not to do any actual reading ?

Rémy



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: svn commit: r731974 - /tomcat/tc6.0.x/trunk/STATUS.txt

Posted by Mark Thomas <ma...@apache.org>.
remm@apache.org wrote:
>  * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=36923
>    If EL is disabled, treat it as template text
>    http://svn.apache.org/viewvc?rev=730590&view=rev
>    +1: markt
> +   0: remm (needs TCK testing)
The TCK passes for me.

>  * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=37458
> @@ -274,10 +275,11 @@
>    Use jar url and tag file path to uniquely ID a tag file to prevent naming
>    clashes
>    +1: markt
> -  -1: 
> +  -1: remm (e.printStackTrace in the patch, and maybe usage of URL constructs which could lead to issues
> +            when not filesystem based; also needs TCK testing)
Sorry - I'll fix the exception handling.
The TCK passes for me.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org