[jira] [Created] (HDFS-13954) Add missing cleanupSSLConfig() call for TestTimelineClient test

["Aki Tanaka (JIRA)" <ji...@apache.org>]

Aki Tanaka created HDFS-13954:
---------------------------------

             Summary: Add missing cleanupSSLConfig() call for TestTimelineClient test
                 Key: HDFS-13954
                 URL: https://issues.apache.org/jira/browse/HDFS-13954
             Project: Hadoop HDFS
          Issue Type: Bug
          Components: test
            Reporter: Aki Tanaka


Tests that setup SSLConfigs can leave conf-files lingering unless they are cleaned up via {{KeyStoreTestUtil.cleanupSSLConfig}} call. TestTimelineClient test is missing this call.

If the cleanup method is not called explicitly, a modified ssl-client.xml is left in {{test-classes}}, might affect to subsequent test cases.

 

There was a similar report in HDFS-11042, but looks that we need to fix TestTimelineClient test too.

 
{code:java}
$ mvn test -Dtest=TestTimelineClient
$ find .|grep ssl-client.xml$
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/target/test-classes/ssl-client.xml
$ cat ./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/target/test-classes/ssl-client.xml
<?xml version="1.0" encoding="UTF-8" standalone="no"?><configuration>
<property><name>ssl.client.truststore.reload.interval</name><value>1000</value><final>false</final><source>programmatically</source></property>
<property><name>ssl.client.truststore.location</name><value>/Users/tanakah/work/hadoop-2.8.5/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/target/test-dir/trustKS.jks</value><final>false</final><source>programmatically</source></property>
<property><name>ssl.client.keystore.keypassword</name><value>clientP</value><final>false</final><source>programmatically</source></property>
<property><name>ssl.client.keystore.location</name><value>/Users/tanakah/work/hadoop-2.8.5/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/target/test-dir/clientKS.jks</value><final>false</final><source>programmatically</source></property>
<property><name>ssl.client.truststore.password</name><value>trustP</value><final>false</final><source>programmatically</source></property>
<property><name>ssl.client.keystore.password</name><value>clientP</value><final>false</final><source>programmatically</source></property>
{code}
 

After applying this patch, the ssl-client.xml is not generated.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-dev-help@hadoop.apache.org