[GitHub] [arrow] jonkeane commented on a change in pull request #11208: ARROW-12871: [R] upgrade to testthat 3e

[GitBox <gi...@apache.org>]

jonkeane commented on a change in pull request #11208:
URL: https://github.com/apache/arrow/pull/11208#discussion_r715100389



##########
File path: r/tests/testthat/helper-expectation.R
##########
@@ -15,13 +15,8 @@
 # specific language governing permissions and limitations
 # under the License.
 
-expect_as_vector <- function(x, y, ignore_attr = FALSE, ...) {
-  expect_fun <- if (ignore_attr) {
-    expect_equivalent
-  } else {
-    expect_equal
-  }
-  expect_fun(as.vector(x), y, ...)
+expect_as_vector <- function(x, y, ...) {

Review comment:
       This is minor, but I wonder if we should take this opportunity to rename this `expect_as_vector_equal` to be super clear we are expecting them to be equal (via `as.vector()`)

##########
File path: r/tests/testthat/test-compute-sort.R
##########
@@ -15,9 +15,7 @@
 # specific language governing permissions and limitations
 # under the License.
 
-context("compute: sorting")
-
-library(dplyr)
+suppressPackageStartupMessages(library(dplyr))

Review comment:
       This might be a little bit odd, but should we create a helper that does this `quiet_library()` so it's a bit less to type?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org