You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ignite.apache.org by brunoml <gi...@git.apache.org> on 2015/12/29 18:17:50 UTC

[GitHub] ignite pull request: Created a property to create the caches autom...

GitHub user brunoml opened a pull request:

    https://github.com/apache/ignite/pull/388

    Created a property to create the caches automatically for hibernate

    Created a property to create the caches automatically for hibernadefault is true. This is the default behavior for ehCache, Hazelcast and others.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/brunoml/ignite ignite-1.5.1-2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/388.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #388
    
----
commit 5bab7fc1dfc2d26afa1b8071b24d23d8cf807c8f
Author: brunol <br...@me.com.br>
Date:   2015-12-29T17:13:03Z

    - Created a property to create the caches automatically for hibernate, default is true.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Re: [GitHub] ignite pull request: Created a property to create the caches autom...

Posted by Denis Magda <dm...@gridgain.com>.

Hi Bruno,

Thanks for paying interest in Apache Ignite and contributing to it.

However would you mind following our contribution process described here [1]
At least you should run tests checking that nothing is broken and add 
new tests that will validate that your changes work as expected.


[1] 
https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-1.CreateGitHubpull-request

Regards,
Denis

On 12/29/2015 8:17 PM, brunoml wrote:
> GitHub user brunoml opened a pull request:
>
>      https://github.com/apache/ignite/pull/388
>
>      Created a property to create the caches automatically for hibernate
>
>      Created a property to create the caches automatically for hibernadefault is true. This is the default behavior for ehCache, Hazelcast and others.
>
> You can merge this pull request into a Git repository by running:
>
>      $ git pull https://github.com/brunoml/ignite ignite-1.5.1-2
>
> Alternatively you can review and apply these changes as the patch at:
>
>      https://github.com/apache/ignite/pull/388.patch
>
> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
>
>      This closes #388
>      
> ----
> commit 5bab7fc1dfc2d26afa1b8071b24d23d8cf807c8f
> Author: brunol <br...@me.com.br>
> Date:   2015-12-29T17:13:03Z
>
>      - Created a property to create the caches automatically for hibernate, default is true.
>
> ----
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---