[jira] [Comment Edited] (HADOOP-15717) TGT renewal thread does not log IOException

["Xiao Chen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-15717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16645635#comment-16645635 ] 

Xiao Chen edited comment on HADOOP-15717 at 10/10/18 10:34 PM:
---------------------------------------------------------------

Thanks [~snemeth] for the new rev, and thanks [~rkanter] for reading my mind. :)

The logging _can_ be done with slf4j parameterized logging. See https://www.slf4j.org/apidocs/org/slf4j/Logger.html

For example, the following will log ie into the message with its stacktrace.
{noformat}
            LOG.error("TGT is destroyed. Aborting renew thread for {}.", getUserName(), ie);
{noformat}


was (Author: xiaochen):
Thanks [~snemeth] for the new rev.

The logging _can_ be done with slf4j parameterized logging. See https://www.slf4j.org/apidocs/org/slf4j/Logger.html

For example, the following will log ie into the message with its stacktrace.
{noformat}
            LOG.error("TGT is destroyed. Aborting renew thread for {}.", getUserName(), ie);
{noformat}

> TGT renewal thread does not log IOException
> -------------------------------------------
>
>                 Key: HADOOP-15717
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15717
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Szilard Nemeth
>            Assignee: Szilard Nemeth
>            Priority: Major
>         Attachments: HADOOP-15717.001.patch, HADOOP-15717.002.patch
>
>
> I came across a case where tgt.getEndTime() was returned null and it resulted in an NPE, this observation was popped out of a test suite execution on a cluster. The reason for logging the {{IOException}} is that it helps to troubleshoot what caused the exception, as it can come from two different calls from the try-catch.
> I can see that [~gabor.bota] handled this with HADOOP-15593, but apart from logging the fact that the ticket's {{endDate}} was null, we have not logged the exception at all.
> With the current code, the exception is swallowed and the thread terminates in case the ticket's {{endDate}} is null. 
> As this can happen with OpenJDK for example, it is required to print the exception (stack trace, message) to the log.
> The code should be updated here: https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java#L918



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org