[GitHub] [incubator-yunikorn-k8shim] yangwwei commented on a change in pull request #81: [YUNIKORN-28] Support validating yunikorn-configs before admitting it

[GitBox <gi...@apache.org>]

yangwwei commented on a change in pull request #81: [YUNIKORN-28] Support validating yunikorn-configs before admitting it
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/81#discussion_r390607337
 
 

 ##########
 File path: deployments/admission-controllers/scheduler/README.md
 ##########
 @@ -56,6 +59,28 @@ kubectl get pod task0 -o yaml
 
 you'll see the `schedulerName` has been injected with value `yunikorn`.
 
+#### Validations
+
+After the admission controller is started, the config-map named `yunikorn-configs` can be validated
+ before it's created or updated, thus update/creation request with invalid content will be denied immediately and
+ the error cause will be returned to the client.
 
 Review comment:
   Can we rephrase this to: 
   
   YuniKorn loads its configuration from a configmap called `yunikorn-configs`, this admission controller adds a web-hook to validate the `update` and `create` requests for this configmap. It is a safeguard to protect the scheduler not to load invalid configuration, by rejecting such requests.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org