[GitHub] [superset] riahk commented on pull request #12311: fix(alert/report): add/edit modal can't be saved

[GitBox <gi...@apache.org>]

riahk commented on pull request #12311:
URL: https://github.com/apache/superset/pull/12311#issuecomment-755578118


   Let's make sure this is thoroughly tested. I added the `fetchError` logic because API errors were causing `GET` calls in edit mode to fall into an infinite loop. There should have been logic to clear the error after a successful call (should be in the `hooks.ts` file), so it's possible that logic was just faulty? Either way I don't think we should just remove the error check.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org